This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
try to fix race condition causing exit code 227 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dwightguth, would you be interested in addressing the merge conflicts and updating it so we can try to get this in? |
Conflicts: nailgun-server/src/main/java/com/martiansoftware/nailgun/NGSession.java
|
I have not tested this yet, but I believe the merged version should address your issues. |
denji
pushed a commit
to closure-gun/nailgun
that referenced
this pull request
Jul 13, 2015
denji
pushed a commit
to closure-gun/nailgun
that referenced
this pull request
Jul 13, 2015
denji
pushed a commit
to closure-gun/nailgun
that referenced
this pull request
Jul 21, 2015
|
Note that we are still seeing 227 errors with buckd/nailgun even after facebook/buck#262 was closed. They are much less frequent, but I wonder if they might go away entirely if this got merged? I haven't been able to diagnose any further, as yet. |
|
I suggest closing this in favor of #74 because it contains a more up-to-date fix. |
|
Closing all pull requests older than 6 months; please reopen if it is still relevant |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever I tried to run nailgun, I would always see intermittent socket disconnects causing the client to return error code 227 before it had finished printing everything to stdout/stderr. After I made this modification to the code, those went away. I believe what is happening is that socket.close does not wait for all the data to be sent to the client before breaking the connection.