Add Node.js version 10 for CI (#1909)

Summary: **Summary** This PR adds nodejs version `10` for the Travis Ci build Details: * https://github.com/nodejs/Release#end-of-life-releases * https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions ![image](https://user-images.githubusercontent.com/25740248/47252831-f1f67580-d485-11e8-8ae0-1525cfd154df.png) **Test Plan** Travis CI test Pull Request resolved: #1909 Differential Revision: D10487838 fbshipit-source-id: 98d98ea38da66752c6c73fd379acb024058f09a3
facebookarchive · Oct 22, 2018 · 4a9a6a8 · 4a9a6a8
1 parent 11d7379
commit 4a9a6a8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -2,6 +2,7 @@ language: node_js
 
 node_js:
 - 8
+- 10
 
 sudo: false
 

diff --git a/package.json b/package.json
@@ -84,8 +84,11 @@
     "vinyl-buffer": "^1.0.0",
     "webpack-stream": "^4.0.0"
   },
+  "resolutions": {
+    "gulp/**/natives": "1.1.3"
+  },
   "devEngines": {
-    "node": "8.x || 9.x",
+    "node": "8.x || 9.x || 10.x",
     "npm": "2.x || 3.x || 5.x || 6.x"
   },
   "jest": {

diff --git a/yarn.lock b/yarn.lock
@@ -4207,9 +4207,9 @@ nan@^2.3.0:
   version "2.8.0"
   resolved "https://registry.yarnpkg.com/nan/-/nan-2.8.0.tgz#ed715f3fe9de02b57a5e6252d90a96675e1f085a"
 
-natives@^1.1.0:
-  version "1.1.1"
-  resolved "https://registry.yarnpkg.com/natives/-/natives-1.1.1.tgz#011acce1f7cbd87f7ba6b3093d6cd9392be1c574"
+natives@1.1.3, natives@^1.1.0:
+  version "1.1.3"
+  resolved "http://registry.npmjs.org/natives/-/natives-1.1.3.tgz#44a579be64507ea2d6ed1ca04a9415915cf75558"
 
 natural-compare@^1.4.0:
   version "1.4.0"
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,7 @@ language: node_js @@
     node_js:
     - 8
+    - 10
     sudo: false
@@ Expand Down @@