This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Prevent Adding View-Backed Nodes to Layer-Backed Hierarchies #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
commented
Feb 23, 2017
|
|
||
| for (ASDisplayNode *n in @[parent, a, b, c]) { | ||
| for (ASDisplayNode *n in @[parent, a, b, c, d]) { |
There was a problem hiding this comment.
These tests forgot to set layerBacked on the new subnode d so they failed our new assertion. The method name is also super confusing so I updated it.
garrettmoon
approved these changes
Feb 23, 2017
| @@ -2551,6 +2551,11 @@ - (void)_insertSubnode:(ASDisplayNode *)subnode atSubnodeIndex:(NSInteger)subnod | |||
| return; | |||
| } | |||
|
|
|||
| if (self.layerBacked && !subnode.layerBacked) { | |||
| ASDisplayNodeFailAssert(@"Cannot add a view-backed node as a subnode of a layer-backed node. Supernode: %@, subnode: %@", self, subnode); | |||
There was a problem hiding this comment.
I swear this type of check existed before?
There was a problem hiding this comment.
I think so too, but the test that failed post-change is super old so maybe not… ¯_(ツ)_/¯
There was a problem hiding this comment.
yeah, this is really weird. The check did exist before, but I'm not sure how long ago. We should be pretty worried it vanished lol.
hannahmbanana
pushed a commit
that referenced
this pull request
Feb 23, 2017
* Prevent adding view-backed nodes to layer-backed nodes * Do that in a different diff * Fix the message * Update tests * Fix the fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3038
Doing this will prevent required callbacks like
didMoveToWindowfrom getting sent to our view.