Update cmake_minimum_required to 2.8.12

[brawner]

This has to do with a deprecated policy with the recent release of cmake 3.19.1. A policy about INTERFACE_LINK_LIBRARIES has been deprecated for versions < 2.8.12. The deprecation will produce warnings if an older version is used, or the policy is set to OLD.

More info about the deprecated policy:
https://cmake.org/cmake/help/latest/policy/CMP0022.html

Signed-off-by: Stephen Brawner [email protected]

[facebook-github-bot]

Hi @brawner!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[brawner]

It doesn't look like the test failure is related. Importantly the cmake job succeeded.

Test failure output

Seed = 6964

     1/     1    
    26          
    30          
    38          
    46          
    63          
    69          
    78          
    83          
    88          
   100          
   101          Error => Compression is not deterministic! (seed 6964, test nb 117, line 2329) 
make[1]: *** [test-zstream] Error 1

[Cyan4973]

The test error is unrelated

[Cyan4973]

I'm fine with the suggested change.
The main requirement for 2.8.9 compatibility was to remain compatible with base version of cmake in Ubuntu Precise, which is no longer maintained.

We can now move up to 2.8.12 which corresponds to the base version in Ubuntu Trusty, still in extended support mode.