Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install MSVC runtime shared libraries (DLL) with cmake #2221

Merged
merged 2 commits into from
Jun 30, 2020

Conversation

emmenlau
Copy link
Contributor

@emmenlau emmenlau commented Jun 29, 2020

The cmake based build currently does not install MSVC shared libraries. This seems to be caused by a rather simple issue: The cmake install command is missing the RUNTIME component (see https://cmake.org/cmake/help/latest/command/install.html#installing-targets). The usual install target directory for the RUNTIME is CMAKE_INSTALL_BINDIR.

This PR adds the RUNTIME component to the install command. This should not have any negative consequences for any users. The only behavioral change should be that the shared library (dll) files will be installed into CMAKE_INSTALL_BINDIR on MSVC, which should be a purely positive effect.

@facebook-github-bot
Copy link

Hi @emmenlau!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@terrelln terrelln merged commit 3690fe3 into facebook:dev Jun 30, 2020
@terrelln
Copy link
Contributor

Thanks for the PR @emmenlau!

@emmenlau
Copy link
Contributor Author

Thanks for the quick response!

@emmenlau emmenlau deleted the bda_install_dll branch June 30, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants