Fix playTests.sh #2159
Merged
Fix playTests.sh #2159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
playTests changed variable name
|
Whats different between this patch and Felix's patch? Does the trailing space matter? |
|
Woohoo, it looks like its fixed! That is such a dumb behavior for Appveyor... Thanks @Cyan4973 for fixing all the test failures blocking the release! |
terrelln
approved these changes
May 22, 2020
Yes it does, |
|
Yeah, I presume it is because the variable is quoted. I made that change to support paths with spaces in the name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggered following visual-release compilation test