Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ldm] Reset loadedDictEnd when the context is reset #2150

Merged
merged 3 commits into from
May 19, 2020
Merged

[ldm] Reset loadedDictEnd when the context is reset #2150

merged 3 commits into from
May 19, 2020

Conversation

terrelln
Copy link
Contributor

@terrelln terrelln commented May 18, 2020 •
edited
Loading

  • Invalidate the loadedDictEnd when we reset the context
  • Also invalidate loadedDictEnd when we do overflow correction

Added a test that produces an out of bounds offset before this fix, and works after.

Credit to OSS-Fuzz

@terrelln terrelln force-pushed the ldm-dict-reset branch 2 times, most recently from 37aa1a4 to 7b317b4 Compare May 18, 2020 22:59
@terrelln
Copy link
Contributor Author

Added a test.

@terrelln terrelln merged commit 9778f46 into facebook:dev May 19, 2020
@terrelln terrelln mentioned this pull request May 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
bug CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terrelln @Cyan4973 @felixhandte @facebook-github-bot