New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] removing -f test (grep usage not supported on mac) #2132

Merged

Cyan4973 merged 1 commit into facebook:dev from bimbashrestha:grep-rm-test

May 12, 2020

Contributor

bimbashrestha commented May 12, 2020

echo "start" | grep -f - tmp_grep

doesn't work consistently on all greps (eg: fails on mac) so we shouldn't require that zstdgrep support that usage. Removing that test


          removing -f test (grep usage not supported on mac)

0453cfa

facebook-github-bot added the CLA Signed label

Cyan4973 approved these changes

View reviewed changes

Cyan4973 merged commit 5dca17d into facebook:dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels