Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zdict] Stabilize ZDICT_finalizeDictionary() #2111

Merged
merged 1 commit into from
May 7, 2020
Merged

[zdict] Stabilize ZDICT_finalizeDictionary() #2111

merged 1 commit into from
May 7, 2020

Conversation

terrelln
Copy link
Contributor

@terrelln terrelln commented May 7, 2020

  • Move to stable API
  • Improve docs

Closes #1816

felixhandte
felixhandte approved these changes May 7, 2020
View reviewed changes
lib/dictBuilder/zdict.h Outdated
* Samples must be stored concatenated in a flat buffer `samplesBuffer`,
* supplied with an array of sizes `samplesSizes`, providing the size of each
* sample in order. The samples are used to construct the statistics, so they
* should be representative of you will compress with this dictionary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing word.

@terrelln terrelln merged commit 45c66dd into facebook:dev May 7, 2020
@Cyan4973 Cyan4973 mentioned this pull request May 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixhandte felixhandte felixhandte approved these changes

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No stable zdict.h API for rolling your own dictionaries
4 participants
@terrelln @Cyan4973 @felixhandte @facebook-github-bot