Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] handling case where prefix is NULL or 0 sized in refPrefix_advanced #2075

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

bimbashrestha
Copy link
Contributor

Adding refPrefix to our dictionary_round_trip fuzzer caused it to crash on

DEBUGLOG(4, "ZSTD_compress_insertDictionary (dictSize=%u)", (U32)dictSize);
if ((dict==NULL) || (dictSize<8)) {
RETURN_ERROR_IF(dictContentType == ZSTD_dct_fullDict, dictionary_wrong);
return 0;
}

handling null case on refPrefix advanced like in loadDictionary. I'll rebase the patch-from pr on top of this after it lands.

@Cyan4973
Copy link
Contributor

Cyan4973 commented Apr 7, 2020

nice catch !

@bimbashrestha bimbashrestha merged commit c0d4b2b into facebook:dev Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants