Use crossAxisOwnerSize instead of ownerHeight in cross axis bound call #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D66736539 |
facebook#1763) Summary: X-link: facebook/react-native#48080 Small bug that I noticed while doing intrinsic sizing. We have the ownerHeight as the axis size despite bounding the length of the cross axis. This should therefore be the crossAxisOwnerSize, which might be the width in some cases Changelog: [Internal] Differential Revision: D66736539
joevilches
force-pushed
the
export-D66736539
branch
from
e252b97 to
f3d3a0b
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2024
facebook#48080) Summary: X-link: facebook/yoga#1763 Small bug that I noticed while doing intrinsic sizing. We have the ownerHeight as the axis size despite bounding the length of the cross axis. This should therefore be the crossAxisOwnerSize, which might be the width in some cases Changelog: [Internal] Differential Revision: D66736539
|
This pull request was exported from Phabricator. Differential Revision: D66736539 |
|
This pull request has been merged in 5478812. |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 6, 2024
Summary: X-link: facebook/yoga#1763 X-link: facebook/react-native#48080 Small bug that I noticed while doing intrinsic sizing. We have the ownerHeight as the axis size despite bounding the length of the cross axis. This should therefore be the crossAxisOwnerSize, which might be the width in some cases Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66736539 fbshipit-source-id: 528fc438b3327cd6f7890ea0ba408e4ce7b0f02c
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 6, 2024
#48080) Summary: X-link: facebook/yoga#1763 Pull Request resolved: #48080 Small bug that I noticed while doing intrinsic sizing. We have the ownerHeight as the axis size despite bounding the length of the cross axis. This should therefore be the crossAxisOwnerSize, which might be the width in some cases Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D66736539 fbshipit-source-id: 528fc438b3327cd6f7890ea0ba408e4ce7b0f02c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#48080
Small bug that I noticed while doing intrinsic sizing. We have the ownerHeight as the axis size despite bounding the length of the cross axis. This should therefore be the crossAxisOwnerSize, which might be the width in some cases
Changelog: [Internal]
Differential Revision: D66736539