Add reset() method to CSSNode #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public CSSAlign alignItems; | ||
| public CSSAlign alignSelf; | ||
| public CSSPositionType positionType; | ||
| public CSSWrap flexWrap; |
There was a problem hiding this comment.
Why? I'd venture default values are there for a reason?
There was a problem hiding this comment.
Ah, just saw reset() below, ignore.
|
See my inlines, otherwise
Not a big fan of the breaking API change, but as long as you fix usages, I'll allow it. |
|
@foghina What API break? |
|
|
@foghina Ah, I thought CSSLayout was package-private. Reverted this change to avoid the API break. |
This allows users of css-layout in Java to perform faster resets on CSSNode in cases when you want to recycle instances.
|
Updated the branch:
|
lucasr
added a commit
that referenced
this pull request
Oct 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users of css-layout in Java to perform faster resets on
CSSNode in cases when you want to recycle instances.
CSSLayout.resetResult() was renamed to simply reset() for consistency.