Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Inconsistency: Node is too tall #505

Closed
rigdern opened this issue Apr 12, 2017 · 1 comment
Closed

Web Inconsistency: Node is too tall #505

rigdern opened this issue Apr 12, 2017 · 1 comment

Comments

@rigdern
Copy link

rigdern commented Apr 12, 2017 •
edited
Loading

Yoga Test Input

Here's a test case which fails:

<div style="width: 100px; height: 100px; align-items: center; margin-top: 20px;">
  <div style="flex-grow: 0; flex-shrink: 1; justify-content: center;">
    <div style="flex-grow: 1; flex-shrink: 1; background-color: steelblue;">
      <div style="width: 20px; height: 20px; background-color: orange;"></div>
    </div>
  </div>
</div>

Yoga Test Failure Output

      Expected: 20
To be equal to: YGNodeLayoutGetHeight(root_child0)
      Which is: 100

Expected Visual

The blue box is not visible.

image

Actual Visual

The blue box is visible.

image
@woehrl01 woehrl01 mentioned this issue Apr 12, 2017
Closed
facebook-github-bot pushed a commit that referenced this issue Apr 13, 2017
@woehrl01 @facebook-github-bot
Fix sizing of non strech items
0235789 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. See #505
Closes #506

Differential Revision: D4878875

Pulled By: emilsjolander

fbshipit-source-id: ab1174ac7a76dcf20aae7b29a3bc396e11077c4d
facebook-github-bot pushed a commit to facebook/litho that referenced this issue Apr 13, 2017
@woehrl01 @facebook-github-bot
Fix sizing of non strech items
3223edd 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. See facebook/yoga#505
Closes facebook/yoga#506

Differential Revision: D4878875

Pulled By: emilsjolander

fbshipit-source-id: ab1174ac7a76dcf20aae7b29a3bc396e11077c4d
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Apr 13, 2017
@woehrl01 @facebook-github-bot
Fix sizing of non strech items
a82de95 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. See facebook/yoga#505
Closes facebook/yoga#506

Differential Revision: D4878875

Pulled By: emilsjolander

fbshipit-source-id: ab1174ac7a76dcf20aae7b29a3bc396e11077c4d
Maxwell2022 pushed a commit to Maxwell2022/react-native that referenced this issue Apr 19, 2017
@woehrl01
Fix sizing of non strech items
833ef42 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. See facebook/yoga#505
Closes facebook/yoga#506

Differential Revision: D4878875

Pulled By: emilsjolander

fbshipit-source-id: ab1174ac7a76dcf20aae7b29a3bc396e11077c4d
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Apr 28, 2017
@woehrl01 @facebook-github-bot
Fix sizing of non strech items
992e37c 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. This introduces a new useLegacyStretchBehaviour flag on the config to opt out of this change as it is breaking.

See facebook/yoga#505
Closes facebook/yoga#506

Reviewed By: astreet

Differential Revision: D4954016

Pulled By: emilsjolander

fbshipit-source-id: d28bd5d174cd76951fb94df85e3b0cfab7f81ff7
facebook-github-bot pushed a commit to facebook/litho that referenced this issue Apr 28, 2017
@woehrl01 @facebook-github-bot
Fix sizing of non strech items
ec19a50 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. This introduces a new useLegacyStretchBehaviour flag on the config to opt out of this change as it is breaking.

See facebook/yoga#505
Closes facebook/yoga#506

Reviewed By: astreet

Differential Revision: D4954016

Pulled By: emilsjolander

fbshipit-source-id: d28bd5d174cd76951fb94df85e3b0cfab7f81ff7
facebook-github-bot pushed a commit that referenced this issue Apr 28, 2017
@woehrl01 @facebook-github-bot
Fix sizing of non strech items
2035777 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. This introduces a new useLegacyStretchBehaviour flag on the config to opt out of this change as it is breaking.

See #505
Closes #506

Reviewed By: astreet

Differential Revision: D4954016

Pulled By: emilsjolander

fbshipit-source-id: d28bd5d174cd76951fb94df85e3b0cfab7f81ff7
thotegowda pushed a commit to thotegowda/react-native that referenced this issue May 7, 2017
@woehrl01 @thotegowda
Fix sizing of non strech items
ff25dbe 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. See facebook/yoga#505
Closes facebook/yoga#506

Differential Revision: D4878875

Pulled By: emilsjolander

fbshipit-source-id: ab1174ac7a76dcf20aae7b29a3bc396e11077c4d
thotegowda pushed a commit to thotegowda/react-native that referenced this issue May 7, 2017
@woehrl01 @thotegowda
Fix sizing of non strech items
f30dfd1 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. This introduces a new useLegacyStretchBehaviour flag on the config to opt out of this change as it is breaking.

See facebook/yoga#505
Closes facebook/yoga#506

Reviewed By: astreet

Differential Revision: D4954016

Pulled By: emilsjolander

fbshipit-source-id: d28bd5d174cd76951fb94df85e3b0cfab7f81ff7
@rigdern
Copy link
Author

rigdern commented Sep 19, 2017

I confirmed this doesn't repro in master (bcc36cc).

@rigdern rigdern closed this as completed Sep 19, 2017
vincentriemer pushed a commit to vincentriemer/yoga-dom that referenced this issue May 9, 2018
@woehrl01 @facebook-github-bot
Fix sizing of non strech items
cb7d99b 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. See facebook/yoga#505
Closes facebook/yoga#506

Differential Revision: D4878875

Pulled By: emilsjolander

fbshipit-source-id: ab1174ac7a76dcf20aae7b29a3bc396e11077c4d
vincentriemer pushed a commit to vincentriemer/yoga-dom that referenced this issue May 9, 2018
@woehrl01 @facebook-github-bot
Fix sizing of non strech items
432798b 
Summary:
Fixes the sizing of items so that under most scenarios it calcultes its height by it's content for non exact measurings. This introduces a new useLegacyStretchBehaviour flag on the config to opt out of this change as it is breaking.

See facebook/yoga#505
Closes facebook/yoga#506

Reviewed By: astreet

Differential Revision: D4954016

Pulled By: emilsjolander

fbshipit-source-id: d28bd5d174cd76951fb94df85e3b0cfab7f81ff7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rigdern