Update curve25519-dalek to 4.0.0-pre.5
#86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Thanks for this! I will add an all-features test in a follow-up. |
kevinlewi
added a commit
that referenced
this pull request
Sep 24, 2024
* Fix Clippy (#85) * Update `curve25519-dalek` to 4.0.0-pre.5 (#86) * Update `curve25519-dalek` * Improve documentation * Adding all-features CI test (#87) * Upgrade `p256` to v0.12 (#90) * Upgrade `p256` to v0.12 * Upgrade MSRV to 1.60 (cherry picked from commit daa8dc0) * Replace `json` with `serde_json` (#92) (cherry picked from commit c8de516) * Fix Clippy (#96) (cherry picked from commit 74eaebe) * Depend on `ProjectivePoint: ToEncodedPoint` (#95) (cherry picked from commit 0409db6) * Update `curve25519-dalek` (#94) (cherry picked from commit 2787151) * Use explicit crate features (#100) (cherry picked from commit 5bce3e3) * Bump `curve25519-dalek` to v4.0.0-rc.1 (#102) (cherry picked from commit 8363d26) * Test P-384 (#84) (cherry picked from commit 83eb78b) * Update RustCrypto dependencies to v0.13 (#106) (cherry picked from commit 8b895cc) * Update curve25519-dalek requirement from =4.0.0-rc.1 to =4.0.0-rc.2 (#108) Updates the requirements on [curve25519-dalek](https://github.com/dalek-cryptography/curve25519-dalek) to permit the latest version. - [Release notes](https://github.com/dalek-cryptography/curve25519-dalek/releases) - [Changelog](https://github.com/dalek-cryptography/curve25519-dalek/blob/main/CHANGELOG.md) - [Commits](dalek-cryptography/curve25519-dalek@4.0.0-rc.1...4.0.0-rc.2) --- updated-dependencies: - dependency-name: curve25519-dalek dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 4bd2cf4) * Updating dual-license language (#110) (cherry picked from commit f79ebf9) * Bump `curve25519-dalek` to v4.0.0-rc.3 (#113) (cherry picked from commit 209b957) * Bump `curve25519-dalek` to v4 (#116) (cherry picked from commit 0fdfdfd) * Fixing clippy IntoIterator warnings (#123) (cherry picked from commit c0162ec) * Bump actions/checkout from 3 to 4 (#120) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 8da5684) * Updating setup-rust-action (#125) (cherry picked from commit 59e3fed) * Test P-521 (#127) (cherry picked from commit 68cc7d3) * Fix ambiguous lifetime elision (#131) (cherry picked from commit 40769f7) * Bump actions/cache from 3 to 4 (#132) Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit c93884a) * Fixups + cherry-picking changes from #101 * Fix Clippy warnings * More fixups, tests passing * Ensure CI runs on branch v0.4 --------- Co-authored-by: daxpedda <[email protected]> Co-authored-by: Kevin Lewi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has now been some significant positive movement on
curve25519, including updated dependencies.I also added the
doc_auto_cfgfeature behind adocsrscfgflag to improve the documentation generated.I guess for us the biggest change is removing all the re-exported crate features. Now
--all-featurescan be used and features are additive, as they should be.CI might need to be improved now, like testing
--all-featuresor 32-bit targets. @kevinlewi I gave you write access, so feel free to add more tests as you deem fit.