Support canceling running RemoteCompaction on remote side #9725
Conversation
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
jay-zhuang
changed the title
| "CompactionJob::Run():Inprogress", | ||
| [&](void* /*arg*/) { my_cs->SetCanceled(true); }); | ||
|
|
||
| s = db_->CompactRange(CompactRangeOptions(), &start, &end); |
There was a problem hiding this comment.
I think this is coming from a saved background error actually. Maybe assert my_cs became true again after the CompactRange().
Does it still work if you make this CompactRange() in a fresh DB or separate test case?
There was a problem hiding this comment.
Nice catch, I updated the test to reopen and then run CompactRange() again, as the compaction failure is a background failure which is not recoverable.
Add the ability to cancel remote compaction on the remote side by setting `OpenAndCompactOptions.canceled` to true. Test Plan: added unittest
jay-zhuang
force-pushed
the
remote_cancel
branch
from
9f2b132 to
80cb60e
Compare
|
@jay-zhuang has updated the pull request. You must reimport the pull request before landing. |
jay-zhuang
force-pushed
the
remote_cancel
branch
from
80cb60e to
34cd9fa
Compare
|
@jay-zhuang has updated the pull request. You must reimport the pull request before landing. |
|
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
) Summary: Add the ability to cancel remote compaction on the remote side by setting `OpenAndCompactOptions.canceled` to true. Pull Request resolved: facebook#9725 Test Plan: added unittest Reviewed By: ajkr Differential Revision: D35018800 Pulled By: jay-zhuang fbshipit-source-id: be3652f9645e0347df429e42a5614d5a9b3a1ec4 Signed-off-by: tabokie <[email protected]>
Add the ability to cancel remote compaction on the remote side by
setting
OpenAndCompactOptions.canceledto true.Test Plan: added unittest