Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subcompaction event API #9311

Closed
wants to merge 9 commits into from
Closed

Add subcompaction event API #9311

wants to merge 9 commits into from

Conversation

jay-zhuang
Copy link
Contributor

Add event callback for subcompaction and adds a sub_job_id to identify it.

@ajkr
Copy link
Contributor

ajkr commented Jan 7, 2022

Looked briefly and it seemed good. Any particular reason it's a draft?

@jay-zhuang jay-zhuang changed the title [WIP] Add subcompaction event API Add subcompaction event API Jan 29, 2022
@jay-zhuang jay-zhuang marked this pull request as ready for review January 31, 2022 16:48
@jay-zhuang jay-zhuang requested a review from ajkr January 31, 2022 16:49
@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@jay-zhuang
Copy link
Contributor Author

Looked briefly and it seemed good. Any particular reason it's a draft?

Sorry for the delay. I changed interface a little bit to have it's own subcompaction_job_info. Because subcompaction cannot get the current version, which makes compaction_job_info missing some table_properties for subcompaction. I find it's hard to explain that in the doc. Separated structure would also make it easier to extend in the future.

ajkr
ajkr approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@ajkr ajkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tabokie tabokie mentioned this pull request Aug 15, 2023
Closed
tabokie pushed a commit to tabokie/rocksdb that referenced this pull request Aug 15, 2023
@jay-zhuang @tabokie
Add subcompaction event API (facebook#9311)
4e4bce0 
Summary:
Add event callback for subcompaction and adds a sub_job_id to identify it.

Pull Request resolved: facebook#9311

Reviewed By: ajkr

Differential Revision: D33892707

Pulled By: jay-zhuang

fbshipit-source-id: 57b5e5e594d61b2112d480c18a79a36751f65a4e
Signed-off-by: tabokie <[email protected]>
@v01dstar v01dstar mentioned this pull request May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkr ajkr ajkr approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jay-zhuang @ajkr @facebook-github-bot