Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WriteBatch rep_ format for RangeDeletion records #3392

Closed
wants to merge 1 commit into from

Conversation

nvanbenschoten
Copy link
Contributor

This is a small amount of general cleanup I made while experimenting with #3391.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Contributor

@yiwu-arbug yiwu-arbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yiwu-arbug
Copy link
Contributor

@nvanbenschoten do you mind signing the CLA? Thanks.

@nvanbenschoten
Copy link
Contributor Author

Huh, I did before but nothing happened. Now it's saying "Email is already associated with an existing contributor."

@yiwu-arbug
Copy link
Contributor

@nvanbenschoten You need to email [email protected] to get the issue resolve. Do you mind doing that?

@nvanbenschoten
Copy link
Contributor Author

@yiwu-arbug email sent!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiwu-arbug is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@nvanbenschoten nvanbenschoten deleted the sstDelRange branch January 23, 2018 21:10
amytai pushed a commit to amytai/rocksdb that referenced this pull request Mar 9, 2018
Summary:
This is a small amount of general cleanup I made while experimenting with facebook#3391.
Closes facebook#3392

Differential Revision: D6788365

Pulled By: yiwu-arbug

fbshipit-source-id: 2716e5aabd5424a4dfdaa954361a62c8eb721ae2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants