-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compression type to options #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging since it was reviewed by @yhchiang. Travis build failure is a known problem, not caused by the merge. |
igorcanadi
added a commit
that referenced
this pull request
Jul 7, 2014
Add compression type to options
Little-Wallace
pushed a commit
to Little-Wallace/rocksdb
that referenced
this pull request
Oct 19, 2020
I needed these changes to run `make` successfully. See this issue which points out the problem and has the same patch solution but at a different point in time: facebook#7352 Signed-off-by: Greg Weber <[email protected]> Co-authored-by: yiwu-arbug <[email protected]>
hunterlxt
pushed a commit
to hunterlxt/rocksdb
that referenced
this pull request
Jul 9, 2021
I needed these changes to run `make` successfully. See this issue which points out the problem and has the same patch solution but at a different point in time: facebook#7352 Signed-off-by: Breezewish <[email protected]> Co-authored-by: Greg Weber <[email protected]>
ronag
pushed a commit
to nxtedition/rocksdb
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add compression type to options
make rocksdbjava
make sample
Reviewers: haobo, yhchiang, sdong, dhruba, rsumbaly, zzbennett, swapnilghike
Reviewed By: yhchiang, sdong
CC: leveldb
Differential Revision: https://reviews.facebook.net/D19473