Fix for Issue:1780 #1831
Closed
Fix for Issue:1780 #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevelittle updated the pull request - view changes |
This test demonstrates that attempting to take a 2nd lock within the same process causes the existing fcntl lock to be dropped
Move the check of lockedFiles to before we attempt to open the lock file This way we avoid opening a file which might already be open. More importantly, we avoid *closing* that file, which would release any fcntl locks that we have, enabling concurrent access from other processes and potential file corruption
For now, we can just #ifdef them out and assume it works
stevelittle
force-pushed
the
issue1780
branch
from
4bc4c04 to
b20be55
Compare
|
@stevelittle updated the pull request - view changes |
|
rebased against master to pick up commit:f289d9f (which fixed the build for OS-X on master) |
|
@IslamAbdelRahman has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Closing this via automation due to lack of activity. If discussion is still needed here, please re-open or create a new/updated issue. |
ajkr
approved these changes
May 24, 2018
There was a problem hiding this comment.
lgtm. I rebased and fixed conflicts here (ajkr@2919a39) if you want to update this PR with that content.
|
@ajkr - Your rebased change looks good to me, thanks for doing that. Please go ahead and merge. |
|
Thanks, replaced with #3993 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 14, 2018
Summary: Rebased and resubmitting #1831 on behalf of stevelittle. The problem is when a single process attempts to open the same DB twice, the second attempt fails due to LOCK file held. If the second attempt had opened the LOCK file, it'll now need to close it, and closing causes the file to be unlocked. Then, any subsequent attempt to open the DB will succeed, which is the wrong behavior. The solution was to track which files a process has locked in PosixEnv, and check those before opening a LOCK file. Fixes #1780. Closes #3993 Differential Revision: D8398984 Pulled By: ajkr fbshipit-source-id: 2755fe66950a0c9de63075f932f9e15768041918
rcane
pushed a commit
to rcane/rocksdb
that referenced
this pull request
Sep 13, 2018
Summary: Rebased and resubmitting facebook#1831 on behalf of stevelittle. The problem is when a single process attempts to open the same DB twice, the second attempt fails due to LOCK file held. If the second attempt had opened the LOCK file, it'll now need to close it, and closing causes the file to be unlocked. Then, any subsequent attempt to open the DB will succeed, which is the wrong behavior. The solution was to track which files a process has locked in PosixEnv, and check those before opening a LOCK file. Fixes facebook#1780. Closes facebook#3993 Differential Revision: D8398984 Pulled By: ajkr fbshipit-source-id: 2755fe66950a0c9de63075f932f9e15768041918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1780
Move the check of lockedFiles to before we attempt to open the lock file
This way we avoid opening a file which might already be open.
More importantly, we avoid closing that file, which would release any
fcntl locks that we have, enabling concurrent access from other processes
and potential file corruption