Print pthread_t in a more safe way #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| fprintf(stdout, "\n"); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you wrap this in an anonymous namespace?
Also, RocksDB's style function name: PrintThreadInfo()
|
Thanks for fixing this! I have a style comment :) |
|
Hi Igor, |
|
No, it's in the global namespace now. Put it on the line 95 please. |
|
Sorry, I am making it right. |
|
Thanks a lot! |
igorcanadi
added a commit
that referenced
this pull request
May 21, 2014
Print pthread_t in a more safe way
ghost
deleted the
BusyJay
pushed a commit
to BusyJay/rocksdb
that referenced
this pull request
Jul 25, 2022
Summary: Instead of using openssl's raw `AES_encrypt` and `AES_decrypt` API, which is a low level call to encrypt or decrypt exact one block (16 bytes), we change to use the `EVP_*` API. The former is deprecated, and will use the default C implementation without AES-NI support. Also the EVP API is capable of handing CTR mode on its own. Test Plan: will add tests Signed-off-by: Yi Wu <[email protected]> Signed-off-by: tabokie <[email protected]>
acelyc111
pushed a commit
to acelyc111/rocksdb
that referenced
this pull request
Jul 21, 2023
Summary: Instead of using openssl's raw `AES_encrypt` and `AES_decrypt` API, which is a low level call to encrypt or decrypt exact one block (16 bytes), we change to use the `EVP_*` API. The former is deprecated, and will use the default C implementation without AES-NI support. Also the EVP API is capable of handing CTR mode on its own. Test Plan: will add tests Signed-off-by: Yi Wu <[email protected]> Signed-off-by: tabokie <[email protected]> (cherry picked from commit 63399df)
acelyc111
pushed a commit
to acelyc111/rocksdb
that referenced
this pull request
Jul 25, 2023
Summary: Instead of using openssl's raw `AES_encrypt` and `AES_decrypt` API, which is a low level call to encrypt or decrypt exact one block (16 bytes), we change to use the `EVP_*` API. The former is deprecated, and will use the default C implementation without AES-NI support. Also the EVP API is capable of handing CTR mode on its own. Test Plan: will add tests Signed-off-by: Yi Wu <[email protected]> Signed-off-by: tabokie <[email protected]> (cherry picked from commit 63399df)
acelyc111
added a commit
to acelyc111/rocksdb
that referenced
this pull request
Aug 7, 2023
Summary: Instead of using openssl's raw `AES_encrypt` and `AES_decrypt` API, which is a low level call to encrypt or decrypt exact one block (16 bytes), we change to use the `EVP_*` API. The former is deprecated, and will use the default C implementation without AES-NI support. Also the EVP API is capable of handing CTR mode on its own. Test Plan: will add tests Signed-off-by: Yi Wu <[email protected]> Signed-off-by: tabokie <[email protected]> (cherry picked from commit 63399df)
acelyc111
pushed a commit
to acelyc111/rocksdb
that referenced
this pull request
Aug 7, 2023
Summary: Instead of using openssl's raw `AES_encrypt` and `AES_decrypt` API, which is a low level call to encrypt or decrypt exact one block (16 bytes), we change to use the `EVP_*` API. The former is deprecated, and will use the default C implementation without AES-NI support. Also the EVP API is capable of handing CTR mode on its own. Test Plan: will add tests Signed-off-by: Yi Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this patch will fix the bug i mentioned in #155.
[1] How to print pthread_t