Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompactRange() always compacts to bottommost level for leveled compaction #11468

Closed
wants to merge 7 commits into from
Closed

CompactRange() always compacts to bottommost level for leveled compaction #11468

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
971fb1e
Add unit tests.
cbi42 May 19, 2023
64aa144
Manual compaction with level compaction always try to compact to bott…
cbi42 May 19, 2023
136c83e
Make kIfHaveCompactionFilter behave like
cbi42 May 20, 2023
026a21a
Fix unit tests.
cbi42 May 22, 2023
de567b6
Update comments.
cbi42 May 30, 2023
707d267
Add change log compact_range_to_bottom.md.
cbi42 May 31, 2023
1952285
Update change log and minor code change.
cbi42 Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db/db_impl/db_impl_compaction_flush.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1235,7 +1235,7 @@ Status DBImpl::CompactRangeInternal(const CompactRangeOptions& options,
// or kIfHaveCompactionFilter with compaction filter set.
s = RunManualCompaction(
cfd, final_output_level, final_output_level, options, begin,
end, exclusive, !trim_ts.empty() /* disallow_trivial_move */,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intra-level compaction does not allow trivial move anyway.

end, exclusive, true /* disallow_trivial_move */,
next_file_number /* max_file_num_to_ignore */, trim_ts);
}
}
Expand Down
3 changes: 2 additions & 1 deletion unreleased_history/behavior_changes/compact_range_to_bottom.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
For Leveled Compaction users, `CompactRange()` will now always try to compact to the last non-empty level. (#11468)
For Leveled Compaction users, `CompactRange()` will now always try to compact to the last non-empty level. (#11468)
For Leveled Compaction users, `CompactRange()` with `bottommost_level_compaction = BottommostLevelCompaction::kIfHaveCompactionFilter` will behave similar to `kForceOptimized` in that it will skip files created during this manual compaction when compacting files in the bottommost level. (#11468)