Clean up PrepareOptions semantics #10387
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up PrepareOptions semantics: - If an option has not changed (via Configure), do not run Prepare on it
This reverts commit 2ebabec.
PrepareOptions is now called under fewer circumnstances. - If invoke_prepare_options = false, it is not called during the configuration process - If invoke_prepare_options = true, PrepareOptions will only be called for the base object (the one invoking Configure) and on objects whose configuration was changed by this invocation. In other words, if the configuration of an object has not changed, it will not be prepared again. -f invoke_prepare_options = true and the option itself is marked as "do not prepare", it will not be prepared even if its configuration has changed.
mrambacher
changed the title
This was referenced Aug 4, 2022
|
@pdillinger @ajkr Any chance of a review? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up PrepareOptions semantics: