Skip to content

Commit

Permalink
Explicitly mark destructors with override (#13212)
Browse files Browse the repository at this point in the history
Summary:
I saw these compiler warnings while preparing for the 9.10 release:

```cpp
'~CompactOnDeletionCollectorFactory' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]

'~CompactForTieringCollectorFactory' overrides a destructor but is not marked 'override' [-Werror,-Wsuggest-destructor-override]
```

This code is from a while ago so I assume that this CI check has been failing for quite some time. We should still clean this up to avoid confusion in the future.

Pull Request resolved: #13212

Test Plan: Existing CI checks should pass, and we should not see this CI check failure the next time we try to make a release/patch.

Reviewed By: jaykorean

Differential Revision: D67287794

Pulled By: archang19

fbshipit-source-id: a11230a919c0b7ef21a7219bf05f567d3d44b2d1
  • Loading branch information
archang19 committed Dec 16, 2024
1 parent 6e8dc74 commit ae8fb3e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/rocksdb/utilities/table_properties_collectors.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class CompactOnDeletionCollectorFactory
size_t deletion_trigger,
double deletion_ratio);

~CompactOnDeletionCollectorFactory() {}
~CompactOnDeletionCollectorFactory() override {}

TablePropertiesCollector* CreateTablePropertiesCollector(
TablePropertiesCollectorFactory::Context context) override;
Expand Down Expand Up @@ -108,7 +108,7 @@ class CompactForTieringCollectorFactory
// for what entry is eligible.
CompactForTieringCollectorFactory(double compaction_trigger_ratio);

~CompactForTieringCollectorFactory() {}
~CompactForTieringCollectorFactory() override {}

TablePropertiesCollector* CreateTablePropertiesCollector(
TablePropertiesCollectorFactory::Context context) override;
Expand Down

0 comments on commit ae8fb3e

Please sign in to comment.