[website] s/class/className/ in MDX #4716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were generating warnings in dev mode. Docusaurus uses MDX which converts the entire markdown into React components. As such, you need to use the same props. The site _works_ but I think that's just because React ultimately passes everything onto the DOM node now. Better to just do the "right" thing. FWIW MDX does mention this in their docs: https://mdxjs.com/docs/what-is-mdx/#markdown-for-the-component-era
|
@zpao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were generating warnings in dev mode. Docusaurus uses MDX which converts the entire markdown into React components. As such, you need to use the same props.
The site works but I think that's just because React ultimately passes everything onto the DOM node now. Better to just do the "right" thing.
FWIW MDX does mention this in their docs:
https://mdxjs.com/docs/what-is-mdx/#markdown-for-the-component-era