Activate LSP for schema and schema extension files #4652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I'm curious how/if you were able to verify these changes. This LSP stuff can be hard to test (especially when they require changes to the VSCode extension as well) |
tobias-tengler
force-pushed
the
activate-lsp-for-graphql-files
branch
from
9c8e9f5 to
b49312f
Compare
|
Yes, I was able to verify it. I started the extension development host and opened my lsp playground repository, which is configured to point to the locally built relay binary. I then observed the extension displaying the |
captbaritone
requested changes
Mar 15, 2024
|
@captbaritone Addressed :) |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@captbaritone merged this pull request in 964e078. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for adding LSP support for schema and schema extension files.