[relay-lsp] Support go to definition for arguments #4605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Exciting! Feel free to ping me when this PR is ready to review. |
tobias-tengler
changed the title
tobias-tengler
force-pushed
the
lsp-argument-support
branch
2 times, most recently
from
35123da to
9b8cd7f
Compare
tobias-tengler
changed the title
|
@captbaritone ready to review :) |
tobias-tengler
force-pushed
the
lsp-argument-support
branch
from
54b6cab to
fa2868f
Compare
tobias-tengler
force-pushed
the
lsp-argument-support
branch
from
fa2868f to
116e859
Compare
captbaritone
reviewed
Mar 1, 2024
|
Looks good overall. Just one question (see inline comments) before I import. |
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@captbaritone merged this pull request in bb41169. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.