FIX(Graphql): Add support for input with default values

[eMerzh]

Hello here 👋

We have a few inputs with default required fields that have default values like here :

input StoryPinInput {
  id: ID!
  isGlobal: Boolean! = false
}

but the TS generated for this look like

export type StoryPinInput = {
  id: string;
  isGlobal: boolean;
};

which is not ideal ...

so i marked the field as optional if it has a default :)

[eMerzh]

@captbaritone sorry for the ping 🥹 .... is there a way to bump those PRs before they go down the black hole of 2nd page ?

if there's something we can do to help ? 🤷

[captbaritone]

Sorry for the delayed response. Can you add a fixture test here? https://github.com/facebook/relay/tree/main/compiler/crates/relay-typegen/tests/generate_typescript/fixtures I think the test schema has an example you can trigger here:

relay/packages/relay-test-utils-internal/testschema.graphql

Line 677 in 54586ec

nameWithDefaultArgs(capitalize: Boolean! = false): String

Maybe you could also ensure there'a fixture test that validates what we do for Flow in this case?

Info on updating fixture tests can be found here: https://github.com/facebook/relay/blob/main/.github/CONTRIBUTING.md#pull-requests

Defaults in GraphQL are confusing, but I believe we should should ensure this generates { isGlobal?: boolean } and not { isGlobal: boolean | null | undefined } since I believe with required arguments with defaults you are permitted to omit the argument but not pass an explicit null.

[eMerzh]

awesome! ❤️ .... i'll take a look at that

[eMerzh]

here... i hope it's better now :)

tried to not add input but i prefer avoid touching too much other tests to add this

[captbaritone]

Would you mind adding this same fixture to the Flow tests?

https://github.com/facebook/relay/tree/main/compiler/crates/relay-typegen/tests/generate_flow/fixtures

[eMerzh]

arg, my bad... here they are :)

[captbaritone]

nice!

[facebook-github-bot]

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@captbaritone merged this pull request in 1a57f08.

[eMerzh]

awesome ❤️ thanks for the review