Support multiple Relay project configurations in extension #4238

ernieturner · 2023-03-07T18:02:57Z

Reviving #3972 into a separate PR and taking over for Terence. This mostly just copies that PR into a new one, but also does a few other fixes

Fixes issues were were having with extension publishing with vsce. I updated to the non-deprecated @vscode/vsce updated package. Packaging/publishing has changed a bit now
- Uses esbuild to minify the extension into a single file as recommended by the VSCode docs
- Removes the use of the extension as a yarn workspace. Yarn workspaces and the vsce packager don't play very well together and were causing all sorts of dependency issues when trying to create the extension .vsix file. Since no other parts of this repo were using workspaces (e.g. the website) I removed that and made it so the extension is its own standalone folder.
Clarified and updated extension options around the relay.projects configuration. Also added a section to the README on how to migrate from v1 to v2

I tested this extension in a handful of different projects, some with no configuration needed, some with the old configuration options (which we map to the new one), and workspaces with multiple projects. However, if anyone has the time I'd love to have others try it out. Just run yarn build-local from the vscode-extension directory and manually install the resulting relay-2.0.0.vsix file into VSCode.

Unrelated to the core purpose of this change, but I also added a .nvmrc file to the root of this repo (and removed .nvmrc from the gitignore since running yarn at the root of this repo with Node 18 fails. Not sure if we were intentionally not including .nvmrc files though, so I can revert if needed.

/cc @davidmccabe @captbaritone @tbezman

…rnings

ernieturner · 2023-03-22T21:33:44Z

.nvmrc

@@ -0,0 +1 @@
+16


Let me know if there's a reason we don't want to do this. When I tried running yarn from the root of the repo on Node 18 I was getting

[15:30:49] 'bundleTask' errored after 118 ms [15:30:49] Error: error:0308010C:digital envelope routines::unsupported at new Hash (node:internal/crypto/hash:71:19) at Object.createHash (node:crypto:133:10)

Pretty sure it's a webpack problem with the version we're on: webpack/webpack#14532

ernieturner · 2023-03-22T21:34:55Z

package.json

@@ -20,9 +20,6 @@
    "test-dependencies": "node ./scripts/testDependencies.js",
    "typecheck": "flow check"
  },
-  "workspaces": [
-    "vscode-extension"
-  ],


Using yarn workspaces wrecks havoc with the VSCode extension publishing tool. It fails to find the right dependencies, duplicates deps, etc. I'm not sure if there was benefit we were getting from this, but removing it makes the bundle/publishing of the extension much easier.

ernieturner · 2023-03-22T21:35:32Z

vscode-extension/tsconfig.json

@@ -5,7 +5,7 @@
    "lib": ["es2020"],
    "outDir": "out",
    "rootDir": "src",
-    "sourceMap": true,
+    "sourceMap": false,


No need to generate sourcemap files within the compiled extension output

ernieturner · 2023-03-22T21:36:38Z

vscode-extension/package.json

+    "build-local": "vsce package",
+    "esbuild-base": "esbuild ./src/extension.ts --bundle --outfile=out/extension.js --external:vscode --format=cjs --platform=node",
+    "esbuild": "npm run esbuild-base -- --sourcemap",
+    "esbuild-watch": "npm run esbuild-base -- --sourcemap --watch"


Pretty much just copied this from the VSCode docs https://code.visualstudio.com/api/working-with-extensions/bundling-extension#using-esbuild

ernieturner · 2023-03-22T22:34:58Z

I don't really understand the unit test failures at this point since my changes shouldn't have touched any of that. Maybe the cargo.lock file needs to be updated, not sure.

ernieturner · 2023-03-23T15:40:53Z

vscode-extension/src/compiler.ts

  );

-  terminal.show();


This disables the terminal auto-showing when switching to a workspace that starts the compiler by default. I don't see much reason to auto-show this when switching workspaces and personally find it a bit annoying

…on to the new relay.projects config. Just map the current configs to a project structure internally

Summary: This ports over a subset of the changes from [this PR](#4238) that just fix some build issues with the VSCode extension. This works to build the extension locally, which should in theory also work with the Github Action publish step, but I can't fully verify that since it requires the marketplace PAT to run. However, we **should not** do a publish after this PR merges because the current tagged version is 2.0.0 and we should wait for the other PR to land before we publish, especially since we're not going to publish 2.0.0 and instead are planning on publishing version 1.3.0. Pull Request resolved: #4275 Reviewed By: josephsavona Differential Revision: D45661618 Pulled By: captbaritone fbshipit-source-id: 321f49060ea15608bbb85c85a68de52cdf37b97d

noghartt · 2024-01-30T10:54:46Z

Any update on that PR? What do we need to finish and merge this PR?

cc @captbaritone @tobias-tengler

sho-pb · 2024-02-08T08:01:51Z

Do you plan to release this Pull Request?

I added relay.projects to settings.json as documented, but it did not work correctly and upon investigation I noticed that this PR has not yet been merged.

ldeveber · 2024-02-13T22:13:12Z

Do you plan to release this Pull Request?

I added relay.projects to settings.json as documented, but it did not work correctly and upon investigation I noticed that this PR has not yet been merged.

I just came looking to find out why that wasn't working, since it was documented as a feature. Do we know when this would be released?

ohardy-agrisight · 2024-06-22T11:23:30Z

Same for me, can we merge this MR and do a release ? Required for mono repo :)

net · 2024-06-26T22:07:42Z

What is everyone doing as a workaround to handle monorepos with multiple relay configs?

noghartt · 2024-06-27T00:50:17Z

What is everyone doing as a workaround to handle monorepos with multiple relay configs?

You can pass projects into your relay.config.js like this:

module.exports = {
  root: ".",
  sources: {
    // put here the source of each project, the root dir of each package of your monorepo
  },
  projects: {
    project1: {
      schema: "...",
      language: "typescript",
    },
    // ...
  },
}

net · 2024-06-27T14:42:39Z

@noghartt thank you!

ernieturner-cb added 2 commits March 7, 2023 11:02

Support multiple Relay project configurations in extension

bf226a6

Setup types to be accurate from config

2d2c625

facebook-github-bot added the CLA Signed label Mar 7, 2023

ernieturner mentioned this pull request Mar 22, 2023

[VSCode Extension] Support for multiple relay configs #3972

Closed

Fix vsce publishing for extension, updates docs, remove yarn workspace

c6c3f07

ernieturner marked this pull request as ready for review March 22, 2023 21:13

ernieturner and others added 2 commits March 22, 2023 15:13

Merge branch 'facebook:main' into multi-config-project-support

5bad4a7

Run prettier on README, ignore engines on vscode tasks to clean up wa…

006d65e

…rnings

ernieturner commented Mar 22, 2023

View reviewed changes

ernieturner-cb added 2 commits March 22, 2023 15:39

Also add ignore engines to extension CI jobs

b7f19bf

Try to fix lint errors

1382194

ernieturner commented Mar 22, 2023

View reviewed changes

Try to fix lint errors

d344a5a

Remove call to show terminal on project load

72f9536

ernieturner commented Mar 23, 2023

View reviewed changes

ernieturner-cb and others added 3 commits March 23, 2023 11:03

Fix shown terminal when LSP fails, add debugging tips to README

e75c0d5

Merge branch 'main' into multi-config-project-support

27d8932

Merge branch 'main' into multi-config-project-support

26acd55

ernieturner mentioned this pull request Apr 7, 2023

Create stand-alone PR to fix VSCode extension build #4275

Closed

ernieturner-cb added 2 commits April 7, 2023 16:39

Change approach to support both the previous config options in additi…

e2945d6

…on to the new relay.projects config. Just map the current configs to a project structure internally

Prettier

5f8579d

ernieturner-cb added 2 commits May 22, 2023 14:11

Merge master into branch and fix conflicts

80395d2

Merge master into branch

2cf5047

dantrain mentioned this pull request Jan 28, 2024

Publish Relay vscode extension v2.1.0 #4576

Closed

facebook-github-bot added the shared with relay team label Jan 23, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support multiple Relay project configurations in extension #4238

Support multiple Relay project configurations in extension #4238

ernieturner commented Mar 7, 2023 •

edited

Loading

ernieturner Mar 22, 2023

ernieturner Mar 22, 2023

ernieturner Mar 22, 2023

ernieturner Mar 22, 2023

ernieturner commented Mar 22, 2023

ernieturner Mar 23, 2023

noghartt commented Jan 30, 2024

sho-pb commented Feb 8, 2024 •

edited

Loading

ldeveber commented Feb 13, 2024

ohardy-agrisight commented Jun 22, 2024 •

edited

Loading

net commented Jun 26, 2024

noghartt commented Jun 27, 2024

net commented Jun 27, 2024

Support multiple Relay project configurations in extension #4238

Are you sure you want to change the base?

Support multiple Relay project configurations in extension #4238

Conversation

ernieturner commented Mar 7, 2023 • edited Loading

ernieturner Mar 22, 2023

Choose a reason for hiding this comment

ernieturner Mar 22, 2023

Choose a reason for hiding this comment

ernieturner Mar 22, 2023

Choose a reason for hiding this comment

ernieturner Mar 22, 2023

Choose a reason for hiding this comment

ernieturner commented Mar 22, 2023

ernieturner Mar 23, 2023

Choose a reason for hiding this comment

noghartt commented Jan 30, 2024

sho-pb commented Feb 8, 2024 • edited Loading

ldeveber commented Feb 13, 2024

ohardy-agrisight commented Jun 22, 2024 • edited Loading

net commented Jun 26, 2024

noghartt commented Jun 27, 2024

net commented Jun 27, 2024

ernieturner commented Mar 7, 2023 •

edited

Loading

sho-pb commented Feb 8, 2024 •

edited

Loading

ohardy-agrisight commented Jun 22, 2024 •

edited

Loading