Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support sha256 and md5 algos for local file persister #3878

Closed
wants to merge 4 commits into from

Conversation

tbezman
Copy link
Contributor

@tbezman tbezman commented Apr 16, 2022

Coinbase needs to use SHA256 . We temporarily have been using a custom persist server that devs run locally. Would be nice to have it in the compiler.

I also threw MD5 in here while I was at it.

I updated the docs to tell more of a story around local persisting. I removed the old local persist server example since those use cases should be covered by the local file persister

Copy link
Contributor

@alunyov alunyov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tbezman!

I like the rust part.

What do you think about keeping the example persist script/server? But still adding the new section Local Persisted Queries.

@tbezman
Copy link
Contributor Author

tbezman commented Apr 26, 2022

@alunyov Okay, I've added back the local persist server example. Let me know if we need any other changes?

@facebook-github-bot
Copy link
Contributor

@alunyov has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@eMerzh
Copy link
Contributor

eMerzh commented Jun 10, 2022

Sorry for chiming in after the fact ...

But this is really great :)

Do you think it would be possible to do that without using the "persistor" thing ?
like changing the cacheId in the opreations, but still have access to the operation's text ?

think it"s related to #2747

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants