Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[relay-runtime] Unfreeze JSON object to allow reassignment #2051

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/relay-runtime/util/recycleNodesInto.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function recycleNodesInto<T>(prevData: T, nextData: T): T {

// Assign local variables to preserve Flow type refinement.
const prevArray = Array.isArray(prevData) ? prevData : null;
const nextArray = Array.isArray(nextData) ? nextData : null;
const nextArray = Array.isArray(nextData) ? [].concat(nextData) : null;
if (prevArray && nextArray) {
canRecycle =
nextArray.reduce((wasEqual, nextItem, ii) => {
Expand All @@ -42,7 +42,7 @@ function recycleNodesInto<T>(prevData: T, nextData: T): T {
} else if (!prevArray && !nextArray) {
// Assign local variables to preserve Flow type refinement.
const prevObject = prevData;
const nextObject = nextData;
const nextObject = Object.assign({}, nextData);
const prevKeys = Object.keys(prevObject);
const nextKeys = Object.keys(nextObject);
canRecycle =
Expand Down