Generate prefetchable pagination ASTs

Reviewed By: captbaritone Differential Revision: D63921399 fbshipit-source-id: 7b8795891693b050667e15d3406fb1ddfa6a6501
facebook · Oct 22, 2024 · 9035b32 · 9035b32
1 parent dececd1
commit 9035b32
Show file tree

Hide file tree

Showing 14 changed files with 1,393 additions and 19 deletions.
diff --git a/compiler/crates/relay-codegen/src/build_ast.rs b/compiler/crates/relay-codegen/src/build_ast.rs
@@ -7,6 +7,10 @@
 
 use std::path::PathBuf;
 
+use ::intern::intern;
+use ::intern::string_key::Intern;
+use ::intern::string_key::StringKey;
+use ::intern::Lookup;
 use common::DirectiveName;
 use common::FeatureFlag;
 use common::NamedItem;
@@ -32,9 +36,6 @@ use graphql_ir::Selection;
 use graphql_ir::Value;
 use graphql_ir::VariableDefinition;
 use graphql_syntax::OperationKind;
-use intern::string_key::Intern;
-use intern::string_key::StringKey;
-use intern::Lookup;
 use lazy_static::lazy_static;
 use md5::Digest;
 use md5::Md5;
@@ -595,6 +596,16 @@ impl<'schema, 'builder, 'config> CodegenBuilder<'schema, 'builder, 'config> {
                     })),
                 });
             }
+            if refetch_metadata.is_prefetchable_pagination {
+                refetch_object.push(ObjectEntry {
+                    key: intern!("edgesFragment"),
+                    value: Primitive::GraphQLModuleDependency(GraphQLModuleDependency::Name(
+                        ExecutableDefinitionName::FragmentDefinitionName(FragmentDefinitionName(
+                            format!("{}__edges", fragment.name.item).intern(),
+                        )),
+                    )),
+                });
+            }
 
             metadata.push(ObjectEntry {
                 key: CODEGEN_CONSTANTS.refetch,

diff --git a/compiler/crates/relay-codegen/tests/connections.rs b/compiler/crates/relay-codegen/tests/connections.rs
@@ -47,8 +47,12 @@ pub async fn transform_fixture(fixture: &Fixture<'_>) -> Result<String, String>
     validate_connections(&program, &connection_interface)
         .map_err(|diagnostics| diagnostics_to_sorted_string(fixture.content, &diagnostics))?;
 
-    let next_program =
-        transform_connections(&program, &connection_interface, &defer_stream_interface);
+    let next_program = transform_connections(
+        &program,
+        &connection_interface,
+        &defer_stream_interface,
+        false,
+    );
 
     let mut printed = next_program
         .operations()

diff --git a/compiler/crates/relay-compiler/src/build_project/artifact_generated_types.rs b/compiler/crates/relay-compiler/src/build_project/artifact_generated_types.rs
@@ -138,14 +138,26 @@ impl ArtifactGeneratedTypes {
                 )),
             }
         } else if let Some(refetchable_metadata) = RefetchableMetadata::find(&fragment.directives) {
-            Self {
-                imported_types: "ReaderFragment, RefetchableFragment",
-                ast_type: "ReaderFragment",
-                exported_type: Some(format!(
-                    "RefetchableFragment<\n  {name}$fragmentType,\n  {name}$data,\n  {refetchable_name}$variables,\n>",
-                    name = fragment.name.item,
-                    refetchable_name = refetchable_metadata.operation_name
-                )),
+            if refetchable_metadata.is_prefetchable_pagination {
+                Self {
+                    imported_types: "ReaderFragment, PrefetchableRefetchableFragment",
+                    ast_type: "ReaderFragment",
+                    exported_type: Some(format!(
+                        "PrefetchableRefetchableFragment<\n  {name}$fragmentType,\n  {name}$data,\n  {name}__edges$data,\n  {refetchable_name}$variables,\n>",
+                        name = fragment.name.item,
+                        refetchable_name = refetchable_metadata.operation_name
+                    )),
+                }
+            } else {
+                Self {
+                    imported_types: "ReaderFragment, RefetchableFragment",
+                    ast_type: "ReaderFragment",
+                    exported_type: Some(format!(
+                        "RefetchableFragment<\n  {name}$fragmentType,\n  {name}$data,\n  {refetchable_name}$variables,\n>",
+                        name = fragment.name.item,
+                        refetchable_name = refetchable_metadata.operation_name
+                    )),
+                }
             }
         } else if is_updatable_fragment {
             Self {