Skip to content

Commit

Permalink
Cleanup partial rendering feature flag
Browse files Browse the repository at this point in the history
Summary: (Finally) removes the feature flag for partial rendering, making partial rendering the default unless overridden by the unstable environment configuration.

Reviewed By: davidmccabe

Differential Revision: D45365186

fbshipit-source-id: 979f540a9b69bcd5ec358de7b4355d7eca89ec8e
  • Loading branch information
Joe Savona authored and facebook-github-bot committed Apr 27, 2023
1 parent 46fa2fa commit 6f2f4cf
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 1 addition & 4 deletions packages/relay-runtime/store/RelayModernEnvironment.js
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,7 @@ class RelayModernEnvironment implements IEnvironment {
this.requiredFieldLogger =
config.requiredFieldLogger ?? defaultRequiredFieldLogger;
this._defaultRenderPolicy =
config.UNSTABLE_defaultRenderPolicy ??
RelayFeatureFlags.ENABLE_PARTIAL_RENDERING_DEFAULT === true
? 'partial'
: 'full';
config.UNSTABLE_defaultRenderPolicy ?? 'partial';
this._operationLoader = operationLoader;
this._operationExecutions = new Map();
this._network = wrapNetworkWithLogObserver(this, config.network);
Expand Down
2 changes: 0 additions & 2 deletions packages/relay-runtime/util/RelayFeatureFlags.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import type {Disposable} from '../util/RelayRuntimeTypes';
export type FeatureFlags = {
ENABLE_CLIENT_EDGES: boolean,
ENABLE_VARIABLE_CONNECTION_KEY: boolean,
ENABLE_PARTIAL_RENDERING_DEFAULT: boolean,
ENABLE_REACT_FLIGHT_COMPONENT_FIELD: boolean,
ENABLE_RELAY_RESOLVERS: boolean,
ENABLE_GETFRAGMENTIDENTIFIER_OPTIMIZATION: boolean,
Expand Down Expand Up @@ -46,7 +45,6 @@ export type FeatureFlags = {
const RelayFeatureFlags: FeatureFlags = {
ENABLE_CLIENT_EDGES: false,
ENABLE_VARIABLE_CONNECTION_KEY: false,
ENABLE_PARTIAL_RENDERING_DEFAULT: true,
ENABLE_REACT_FLIGHT_COMPONENT_FIELD: false,
ENABLE_RELAY_RESOLVERS: false,
ENABLE_GETFRAGMENTIDENTIFIER_OPTIMIZATION: false,
Expand Down

0 comments on commit 6f2f4cf

Please sign in to comment.