Add missing class annotations in xplat/js/RKJSModules/Libraries/Relay

Reviewed By: bradzacher Differential Revision: D38086573 fbshipit-source-id: 498cee3593fd9430a41bca61747106c3c2550bc9
facebook · Jul 22, 2022 · 404dd87 · 404dd87
1 parent a8e3665
commit 404dd87
Show file tree

Hide file tree

Showing 18 changed files with 33 additions and 33 deletions.
diff --git a/packages/react-relay/ReactRelayQueryFetcher.js b/packages/react-relay/ReactRelayQueryFetcher.js
@@ -319,7 +319,7 @@ class ReactRelayQueryFetcher {
   }: {
     notifyFirstResult: boolean,
     ...
-  }) {
+  }): void {
     invariant(
       this._fetchOptions,
       'ReactRelayQueryFetcher: `_onQueryDataAvailable` should have been called after having called `fetch`',

diff --git a/packages/react-relay/__flowtests__/ReactRelayFragmentContainer-flowtest.js b/packages/react-relay/__flowtests__/ReactRelayFragmentContainer-flowtest.js
@@ -43,7 +43,7 @@ class BarComponent extends React.Component<{
   requiredProp: string,
   ...
 }> {
-  static defaultProps = {
+  static defaultProps: {defaultProp: string} = {
     defaultProp: 'default',
   };
   getNum(): number {

diff --git a/packages/react-relay/__flowtests__/ReactRelayPaginationContainer-flowtest.js b/packages/react-relay/__flowtests__/ReactRelayPaginationContainer-flowtest.js
@@ -31,13 +31,13 @@ class FooComponent extends React.Component {
     requiredProp: string,
     ...
   };
-  static defaultProps = {
+  static defaultProps: {defaultProp: string} = {
     defaultProp: 'default',
   };
   getNum(): number {
     return 42;
   }
-  render() {
+  render(): React.Node {
     const reqLen = this.props.requiredProp.length;
     const optionalProp = this.props.optionalProp;
 
@@ -157,7 +157,7 @@ module.exports = {
         /** $FlowExpectedError: Foo `getNum` gives number, but `getString` assumes string  **/
         return bad ? 'not good' : ok;
       }
-      render() {
+      render(): React.Node {
         return (
           <Foo
             componentRef={ref => {

diff --git a/packages/react-relay/__flowtests__/ReactRelayRefetchContainer-flowtest.js b/packages/react-relay/__flowtests__/ReactRelayRefetchContainer-flowtest.js
@@ -30,13 +30,13 @@ class FooComponent extends React.Component {
     requiredProp: string,
     ...
   };
-  static defaultProps = {
+  static defaultProps: {defaultProp: string} = {
     defaultProp: 'default',
   };
   getNum(): number {
     return 42;
   }
-  render() {
+  render(): React.Node {
     const reqLen = this.props.requiredProp.length;
     const optionalProp = this.props.optionalProp;
 
@@ -140,7 +140,7 @@ module.exports = {
         /** $FlowExpectedError: Foo `getNum` gives number, but `getString` assumes string  **/
         return bad ? 'not good' : ok;
       }
-      render() {
+      render(): React.Node {
         return (
           <Foo
             componentRef={ref => {

diff --git a/packages/react-relay/relay-hooks/FragmentResource.js b/packages/react-relay/relay-hooks/FragmentResource.js
@@ -176,7 +176,7 @@ class ClientEdgeQueryResultsCache {
     }
   }
 
-  _retain(id: string) {
+  _retain(id: string): {dispose: () => void} {
     const retainCount = (this._retainCounts.get(id) ?? 0) + 1;
     this._retainCounts.set(id, retainCount);
     return {
@@ -479,7 +479,7 @@ class FragmentResourceImpl {
     fragmentRef: mixed,
     request: ConcreteRequest,
     clientEdgeDestinationID: DataID,
-  ) {
+  ): {queryResult: QueryResult, requestDescriptor: RequestDescriptor} {
     const originalVariables = getVariablesFromFragment(
       fragmentNode,
       fragmentRef,

diff --git a/packages/react-relay/relay-hooks/__tests__/useBlockingPaginationFragment-test.js b/packages/react-relay/relay-hooks/__tests__/useBlockingPaginationFragment-test.js
@@ -66,11 +66,11 @@ describe('useBlockingPaginationFragment', () => {
   let Renderer;
 
   class ErrorBoundary extends React.Component<any, any> {
-    state = {error: null};
+    state: any | {error: null} = {error: null};
     componentDidCatch(error: Error) {
       this.setState({error});
     }
-    render() {
+    render(): any | React.Node {
       const {children, fallback} = this.props;
       const {error} = this.state;
       if (error) {

diff --git a/...elay/relay-hooks/__tests__/useBlockingPaginationFragment-with-suspense-transition-test.js b/...elay/relay-hooks/__tests__/useBlockingPaginationFragment-with-suspense-transition-test.js
@@ -58,11 +58,11 @@ describe('useBlockingPaginationFragment with useTransition', () => {
     let Renderer;
 
     class ErrorBoundary extends React.Component<any, any> {
-      state = {error: null};
+      state: any | {error: null} = {error: null};
       componentDidCatch(error: Error) {
         this.setState({error});
       }
-      render() {
+      render(): any | React.Node {
         const {children, fallback} = this.props;
         const {error} = this.state;
         if (error) {

diff --git a/packages/react-relay/relay-hooks/__tests__/useLazyLoadQueryNode-test.js b/packages/react-relay/relay-hooks/__tests__/useLazyLoadQueryNode-test.js
@@ -118,12 +118,12 @@ describe('useLazyLoadQueryNode', () => {
     errorBoundaryDidCatchFn = jest.fn();
 
     class ErrorBoundary extends React.Component<any, any> {
-      state = {error: null};
+      state: any | {error: null} = {error: null};
       componentDidCatch(error: Error) {
         errorBoundaryDidCatchFn(error);
         this.setState({error});
       }
-      render() {
+      render(): any | React.Node {
         const {children, fallback} = this.props;
         const {error} = this.state;
         if (error) {

diff --git a/packages/react-relay/relay-hooks/__tests__/usePaginationFragment-test.js b/packages/react-relay/relay-hooks/__tests__/usePaginationFragment-test.js
@@ -118,11 +118,11 @@ describe.each([
   let unsubscribe;
 
   class ErrorBoundary extends React.Component<any, any> {
-    state = {error: null};
+    state: {error: ?Error} = {error: null};
     componentDidCatch(error: Error) {
       this.setState({error});
     }
-    render() {
+    render(): React.Node {
       const {children, fallback} = this.props;
       const {error} = this.state;
       if (error) {

diff --git a/packages/react-relay/relay-hooks/__tests__/usePreloadedQuery-test.js b/packages/react-relay/relay-hooks/__tests__/usePreloadedQuery-test.js
@@ -92,7 +92,7 @@ class ErrorBoundary extends React.Component<$FlowFixMe, $FlowFixMe> {
     this.setState({error});
   }
 
-  render() {
+  render(): any {
     const {children, fallback} = this.props;
     const {error} = this.state;
     if (error != null) {

diff --git a/packages/react-relay/relay-hooks/__tests__/useRefetchableFragmentNode-test.js b/packages/react-relay/relay-hooks/__tests__/useRefetchableFragmentNode-test.js
@@ -138,11 +138,11 @@ describe.each([
     let Renderer;
 
     class ErrorBoundary extends React.Component<any, any> {
-      state = {error: null};
+      state: {error: ?Error} = {error: null};
       componentDidCatch(error: Error) {
         this.setState({error});
       }
-      render() {
+      render(): React.Node {
         const {children, fallback} = this.props;
         const {error} = this.state;
         if (error) {

diff --git a/packages/react-relay/relay-hooks/react-cache/__tests__/useLazyLoadQuery_REACT_CACHE-test.js b/packages/react-relay/relay-hooks/react-cache/__tests__/useLazyLoadQuery_REACT_CACHE-test.js
@@ -175,12 +175,12 @@ describe('useLazyLoadQuery_REACT_CACHE', () => {
 
       let errorBoundaryDidCatchFn;
       class ErrorBoundary extends React.Component<any, any> {
-        state = {error: null};
+        state: {error: ?Error} = {error: null};
         componentDidCatch(error: Error) {
           errorBoundaryDidCatchFn(error);
           this.setState({error});
         }
-        render() {
+        render(): React.Node {
           const {children, fallback} = this.props;
           const {error} = this.state;
           if (error) {

diff --git a/packages/relay-runtime/store/OperationExecutor.js b/packages/relay-runtime/store/OperationExecutor.js
@@ -703,7 +703,7 @@ class Executor<TMutation: MutationParameters> {
   _normalizeFollowupPayload(
     followupPayload: FollowupPayload,
     normalizationNode: NormalizationSelectableNode,
-  ) {
+  ): RelayResponsePayload {
     let variables;
     if (
       normalizationNode.kind === 'SplitOperation' &&

diff --git a/packages/relay-runtime/store/RelayExperimentalGraphResponseHandler.js b/packages/relay-runtime/store/RelayExperimentalGraphResponseHandler.js
@@ -75,7 +75,7 @@ class GraphModeHandler {
     this._populateRecord(record, chunk);
   }
 
-  _populateRecord(parentRecord: Record, chunk: DataChunk) {
+  _populateRecord(parentRecord: Record, chunk: DataChunk): void {
     for (const [key, value] of Object.entries(chunk)) {
       switch (key) {
         case '$streamID':

diff --git a/packages/relay-runtime/store/RelayExperimentalGraphResponseTransform.js b/packages/relay-runtime/store/RelayExperimentalGraphResponseTransform.js
@@ -169,7 +169,7 @@ export class GraphModeNormalizer {
     this.duplicateFieldsAvoided = 0;
   }
 
-  _getStreamID() {
+  _getStreamID(): number {
     return this._nextStreamID++;
   }
 
@@ -195,7 +195,7 @@ export class GraphModeNormalizer {
 
   // TODO: The GraphMode proposal outlines different approachs to derive keys. We
   // can expriment with different approaches here.
-  _getStorageKey(selection: NormalizationField) {
+  _getStorageKey(selection: NormalizationField): string {
     return getStorageKey(selection, this._variables);
   }
 

diff --git a/packages/relay-runtime/store/RelayOptimisticRecordSource.js b/packages/relay-runtime/store/RelayOptimisticRecordSource.js
@@ -97,7 +97,7 @@ class RelayOptimisticRecordSource implements MutableRecordSource {
     return Object.keys(this.toJSON()).length;
   }
 
-  toJSON() {
+  toJSON(): {[DataID]: ?Record} {
     const merged = {...this._base.toJSON()};
     this._sink.getRecordIDs().forEach(dataID => {
       const record = this.get(dataID);

diff --git a/packages/relay-runtime/store/RelayResponseNormalizer.js b/packages/relay-runtime/store/RelayResponseNormalizer.js
@@ -437,7 +437,7 @@ class RelayResponseNormalizer {
     moduleImport: NormalizationModuleImport,
     record: Record,
     data: PayloadData,
-  ) {
+  ): void {
     invariant(
       typeof data === 'object' && data,
       'RelayResponseNormalizer: Expected data for @module to be an object.',
@@ -477,7 +477,7 @@ class RelayResponseNormalizer {
     selection: NormalizationLinkedField | NormalizationScalarField,
     record: Record,
     data: PayloadData,
-  ) {
+  ): void {
     invariant(
       typeof data === 'object' && data,
       'writeField(): Expected data for field `%s` to be an object.',
@@ -569,7 +569,7 @@ class RelayResponseNormalizer {
     selection: NormalizationActorChange,
     record: Record,
     data: PayloadData,
-  ) {
+  ): void {
     const field = selection.linkedField;
     invariant(
       typeof data === 'object' && data,
@@ -662,7 +662,7 @@ class RelayResponseNormalizer {
     selection: NormalizationFlightField,
     record: Record,
     data: PayloadData,
-  ) {
+  ): void {
     const responseKey = selection.alias || selection.name;
     const storageKey = getStorageKey(selection, this._variables);
     const fieldValue = data[responseKey];

diff --git a/packages/relay-test-utils/RelayMockPayloadGenerator.js b/packages/relay-test-utils/RelayMockPayloadGenerator.js
@@ -519,7 +519,7 @@ class RelayMockPayloadGenerator {
     value: mixed | Array<mixed>,
     path: $ReadOnlyArray<string>,
     applicationName: string,
-  ) {
+  ): ?(string | Array<string>) {
     if (value === undefined) {
       return value;
     }