Cherrypick warning and removal of react create class #9771

flarnie · 2017-05-25T02:24:56Z

Edit: Fixed the rest of the issues, this should be good to go now.

Changes:
cherrypick and hand-edit various parts of commits from master to do the following -

add create-react-class and prop-types as dependencies of React
add the deprecation warning for React.createClass and get it from the create-react-class package
add tests for the React.createClass and React.PropTypes deprecation warnings
adds test for create-react-class as used in React

(Original PR message below)

This is a butchered version of #9232 with some of #9399 mixed in. I don't have the tests passing, and there is something not quite right about the way this landed.

Not sure if we want createReactClass or ReactClass.createClass, and updating that caused an error:

src/isomorphic/classic/class/createClass.js was added to master in https://github.com/facebook/react/pull/9399/files
that file is used in src/isomorphic/React.js and itself uses var {Component} = require('ReactBaseClasses');
in 15.6, that line throws Cannot find module 'ReactBaseClasses' from 'createClass.js' and I have no idea why
So instead I left it using the old implementation of 'createClass'

There is still a test failing for ReactART and I have not figure out why. Something in ReactReconcileTransaction.perform triggers TypeError: Cannot read property 'call' of undefined.

I'd be happy for any guidance or tips from folks who made those PRs - @acdlite and/or @bvaughn. I am going to delay doing a RC of 15.6 because this is pretty vital to get right.

Still TODO: improve the deprecation message itself.

gaearon · 2017-05-25T14:41:10Z

in 15.6, that line throws Cannot find module 'ReactBaseClasses' from 'createClass.js' and I have no idea why

I moved ReactComponent.js and ReactPureComponent.js into one file on master (#8918) to work around a www issue but didn’t do this for 15. So this is why the file is not found.

flarnie · 2017-05-25T15:02:18Z

Thank you @gaearon - I was also tired by the time I got that far. Going to fix this up now, and your hint about that file will help.

flarnie · 2017-05-25T19:00:15Z

yarn.lock

    create-hash "^1.1.0"
    inherits "^2.0.1"
+    ripemd160 "^2.0.0"
+    safe-buffer "^5.0.1"
+    sha.js "^2.4.8"



Didn't mean to update all these versions. Will probably make a separate PR with an update to yarn.lock.

**what is the change?:** A couple of bugs and holes were introduced when cherry-picking facebook#9232 onto the 15.6 branch. This fixes them. We also needed to add some logic from facebook#9399 **why make this change?:** To keep tests passing and get this change working. **test plan:** `yarn test` **issue:** facebook#9398

**what is the change?:** - Remove some outdated 'require' statements that got orphaned in 'React.js' - Change 'warning' to 'lowPriorityWarning' for 'React.createClass' - Fix syntax issues in 'React-test' - Use 'creatReactClass' instead of ES6 class in ReactART - Update 'prop-type' dependency to use no higher than 15.7 because 15.8 limits the number of warnings, and this causes a test to fail. - Fix some mixed-up and misnamed variables in `React.js` - Rebase onto commit that updates deprecation messages - Update a test based on new deprecation messages **why make this change?:** These were bugs introduced by rebasing and tests caught the regressions. **test plan:** `yarn test` **issue:** facebook#9398

flarnie · 2017-05-25T20:54:54Z

Weird - yarn prettier changes nothing locally, and when I try to push git says "Everything up-to-date". So not sure why prettier is failing. I'd like to get CI passing again though.

**what is the change?:** I didn't mean to commit changes to `yarn.lock` except for the `prop-types` and `create-react-class` updates. **why make this change?:** To minimize the changes we make to dependency versions. **test plan:** `rm -rf node_modules` `yarn install` `yarn run build` `yarn test`

sophiebits

Why did create-react-class and prop-types move from devDependencies to dependencies?

flarnie · 2017-05-25T21:55:26Z

In #9399 we swap out our own React.createClass for the create-react-class package under the hood, and do the same for React.PropTypes, delegating to prop-types.
It looks like we did the prop-types delegation before 15.6? So not sure if it's a problem in earlier versions that prop-types is a devDependency.
It should get turned into a no-op in production though, right?
Might be worth looking more at how this affects different builds.

But in general - React is actually using those packages until we remove those APIs. Also I added a call to createReactClass to ReactART to fix a cryptic error. Maybe we don't need prop-types but I was copying from #9399

flarnie · 2017-05-25T22:12:10Z

Just looked and I think it seems safer to keep prop-types as a dependency in this version. We could do some extra stuff to make it dev only in this version, but since we will be removing it from React in 16.0 I don't think it's worth any extra effort at this point.

sophiebits · 2017-05-25T22:14:42Z

👍 I don't think it makes a difference. As far as I know we don't ever do a non-dev install of the root package.json's dependencies.

flarnie · 2017-05-25T22:34:56Z

@gaearon - b43f830 removes the // es6 comment.

Wilfred · 2017-05-26T09:38:26Z

Where is the source code of create-react-class? https://www.npmjs.com/package/create-react-class claims that the source code is in this repo, but this repo seems to be depending on the create-react-class package.

gaearon · 2017-05-26T11:37:15Z

It is in the 15.6-dev branch.

Wilfred · 2017-05-26T12:15:18Z

Thanks. For future reference, it's here: https://github.com/facebook/react/tree/15.6-dev/addons/create-react-class

gaearon · 2017-05-26T12:38:48Z

The latest released version is always in 15-stable.

* react-create-class -> create-react-class * Fix issues/bugs introduced by merge conflict resolution **what is the change?:** A couple of bugs and holes were introduced when cherry-picking facebook#9232 onto the 15.6 branch. This fixes them. We also needed to add some logic from facebook#9399 **why make this change?:** To keep tests passing and get this change working. **test plan:** `yarn test` **issue:** facebook#9398 * Move component base classes into a single file (facebook#8918) * More fixes for issues introduced by rebasing **what is the change?:** - Remove some outdated 'require' statements that got orphaned in 'React.js' - Change 'warning' to 'lowPriorityWarning' for 'React.createClass' - Fix syntax issues in 'React-test' - Use 'creatReactClass' instead of ES6 class in ReactART - Update 'prop-type' dependency to use no higher than 15.7 because 15.8 limits the number of warnings, and this causes a test to fail. - Fix some mixed-up and misnamed variables in `React.js` - Rebase onto commit that updates deprecation messages - Update a test based on new deprecation messages **why make this change?:** These were bugs introduced by rebasing and tests caught the regressions. **test plan:** `yarn test` **issue:** facebook#9398 * Reset `yarn.lock` **what is the change?:** I didn't mean to commit changes to `yarn.lock` except for the `prop-types` and `create-react-class` updates. **why make this change?:** To minimize the changes we make to dependency versions. **test plan:** `rm -rf node_modules` `yarn install` `yarn run build` `yarn test` * Run `yarn prettier`

flarnie added this to the 15.6 milestone May 25, 2017

flarnie requested review from sophiebits, bvaughn and acdlite May 25, 2017 02:24

facebook-github-bot added the CLA Signed label May 25, 2017

flarnie force-pushed the cherrypickWarningAndRemovalOfReactCreateClass branch from ba6b6fd to f619d51 Compare May 25, 2017 18:54

flarnie commented May 25, 2017

View reviewed changes

acdlite and others added 4 commits May 25, 2017 13:16

react-create-class -> create-react-class

4c9c859

Move component base classes into a single file (facebook#8918)

3d1062b

flarnie force-pushed the cherrypickWarningAndRemovalOfReactCreateClass branch from f619d51 to 27bbbec Compare May 25, 2017 20:43

flarnie changed the title ~~WIP Cherrypick warning and removal of react create class~~ Cherrypick warning and removal of react create class May 25, 2017

flarnie added 2 commits May 25, 2017 14:09

Run yarn prettier

4a83c04

flarnie mentioned this pull request May 25, 2017

React 15.6 Umbrella #9398

Closed

49 tasks

sophiebits approved these changes May 25, 2017

View reviewed changes

flarnie merged commit b48b259 into facebook:15.6-dev May 25, 2017

renovate bot mentioned this pull request Feb 2, 2018

Update dependency react to v0.14.9 - autoclosed signavio/backbone-rel#29

Closed

1 task

flarnie deleted the cherrypickWarningAndRemovalOfReactCreateClass branch May 25, 2018 17:51

This was referenced Aug 26, 2019

[Snyk] Upgrade react from 15.4.2 to 15.6.2 T0mmykn1fe/blueocean-plugin#3

Open

[Snyk] Upgrade react-dom from 15.4.2 to 15.6.2 T0mmykn1fe/blueocean-plugin#4

Open

This was referenced Jan 23, 2020

[Snyk] Upgrade react from 15.3.2 to 15.6.2 anyulled/todo-react-redux#1

Merged

[Snyk] Upgrade react-dom from 15.3.2 to 15.6.2 anyulled/todo-react-redux#2

Merged

snyk-bot mentioned this pull request Feb 9, 2020

[Snyk] Upgrade react from 15.4.1 to 15.6.2 NetanelHadas/react-native-albums#1

Open

snyk-bot mentioned this pull request Mar 3, 2020

[Snyk] Upgrade: react, react-dom judynjagi/Bucketlist-React-Redux-WebApplication#1

Open

This was referenced Mar 18, 2020

[Snyk] Upgrade: react, react-dom O330oei/sharetribe#3

Merged

[Snyk] Upgrade: react, react-dom godaddy/svgs#51

Closed

[Snyk] Upgrade react from 15.3.1 to 15.6.2 ImranSaadi/react-native-admob#10

Merged

This was referenced Mar 27, 2020

[Snyk] Upgrade: react, react-dom karlhorky/talks#12

Closed

[Snyk] Upgrade: react, react-dom dmitriz/react-pure-component-starter#1

Open

This was referenced Apr 7, 2020

[Snyk] Upgrade react from 15.2.1 to 15.6.2 rangle/react-native-workshop-1#1

Open

[Snyk] Upgrade react from 15.0.2 to 15.6.2 rangle/react-native-workshop#64

Open

[Snyk] Upgrade react from 15.3.1 to 15.6.2 rangle/NavigationExperimentalWorkshop#2

Open

This was referenced May 6, 2020

[Snyk] Upgrade: react, react-dom yamafaktory/babel-react-rollup-starter#117

Open

[Snyk] Upgrade: react, react-dom yamafaktory/buble-react-rollup-starter#95

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cherrypick warning and removal of react create class #9771

Cherrypick warning and removal of react create class #9771

flarnie commented May 25, 2017 •

edited

Loading

gaearon commented May 25, 2017

flarnie commented May 25, 2017

flarnie May 25, 2017

flarnie commented May 25, 2017

sophiebits left a comment

flarnie commented May 25, 2017

flarnie commented May 25, 2017

sophiebits commented May 25, 2017

flarnie commented May 25, 2017

Wilfred commented May 26, 2017

gaearon commented May 26, 2017

Wilfred commented May 26, 2017 •

edited

Loading

gaearon commented May 26, 2017

Cherrypick warning and removal of react create class #9771

Cherrypick warning and removal of react create class #9771

Conversation

flarnie commented May 25, 2017 • edited Loading

gaearon commented May 25, 2017

flarnie commented May 25, 2017

flarnie May 25, 2017

Choose a reason for hiding this comment

flarnie commented May 25, 2017

sophiebits left a comment

Choose a reason for hiding this comment

flarnie commented May 25, 2017

flarnie commented May 25, 2017

sophiebits commented May 25, 2017

flarnie commented May 25, 2017

Wilfred commented May 26, 2017

gaearon commented May 26, 2017

Wilfred commented May 26, 2017 • edited Loading

gaearon commented May 26, 2017

flarnie commented May 25, 2017 •

edited

Loading

Wilfred commented May 26, 2017 •

edited

Loading