Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "comments.json" with this.props.url in the docs tutorial code snippet #963

Merged
merged 1 commit into from
Feb 3, 2014
Merged

Conversation

bobeagan
Copy link
Contributor

Example AJAX request should make use of this.props.url in all places. The first time it is added, the file name is hardcoded in and then switched out for the props reference in the next example.

@petehunt
Copy link
Contributor

petehunt commented Feb 3, 2014

@bobeagan can you sign the CLA at https://developers.facebook.com/opensource/cla? Then we can merge.

@bobeagan
Copy link
Contributor Author

bobeagan commented Feb 3, 2014

I've done that already

petehunt added a commit that referenced this pull request Feb 3, 2014
Replace "comments.json" with this.props.url in the docs tutorial code snippet
@petehunt petehunt merged commit fa046ca into facebook:master Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants