Have jest check for window errors in a similar to console.error logs. Fix for #8260

[franciscofsales]

Fixes #8260

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact [email protected] if you have any questions.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[aweary]

@cpojer does this look right to you?

[cpojer]

sure

[aweary]

@franciscofsales can you resolve the conflicts when you get a chance?

[franciscofsales]

@aweary I synced and added the spyOn for window errors on a few tests. Hope all it's good now. Let me know if I can help any further.

[ttsui]

Any progress on getting this merged?

Was caught out by this problem yesterday and wasted a good half day over it.

[gaearon]

@ttsui I don't understand. This PR is for the React repo infrastructure. It won't affect you as a Jest or React user.

[gaearon]

I'm going to close since we didn't do a good job reviewing and it got stale. The issue still exists but it seems like it's worth solving together with #11098 (comment). Thanks for the PR!