Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have jest check for window errors in a similar to console.error logs. Fixes #8260 #8278

Closed
wants to merge 1 commit into from

Conversation

renderf0x
Copy link

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (npm test).
  5. Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.
  6. If you haven't already, complete the CLA.

…console.error calls. This ensures tests fail when errors are thrown in jsdom event handlers.
@renderf0x
Copy link
Author

Actually, this runs into errors seen in the thread for #8260. Closing, and will reopen if those are resolved.

@renderf0x renderf0x closed this Nov 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants