Move shared logic into AbstractReconcileTransaction to avoid mistakes #7567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not the first time that someone forgets to implement
checkpoint
androllback
on aReconcileTransaction
(see #7558 and #6689) so I decided it was worth moving the shared logic into anAbstractReconcileTransaction
I kinda followed the same pattern used on Transaction.js (export a
Mixin
property) but in this case a plain object would probably be fine.Note that the
ReactNativeReconcileTransaction
was also missing thecheckpoint
androllback
, not sure if intentional or not (not familiar with the React codebase).PS: maybe someone have a better name for it and/or knows a better folder to place it.
/cc @spicyj