Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify "files" field for npm packages #7396

Merged
merged 1 commit into from
Aug 2, 2016
Merged

Conversation

zpao
Copy link
Member

@zpao zpao commented Aug 1, 2016

I had some rogue .rej files get published last release. I cleaned those up but for the future, this is good regardless.

@vjeux
Copy link
Contributor

vjeux commented Aug 2, 2016

<3

@zpao zpao merged commit c5cb5b8 into facebook:master Aug 2, 2016
@zpao zpao added this to the 15-next milestone Aug 2, 2016
@zpao zpao mentioned this pull request Aug 2, 2016
@sebmarkbage
Copy link
Collaborator

sebmarkbage commented Aug 3, 2016

Eh... should I just revert this in #7168 then?

@zpao
Copy link
Member Author

zpao commented Aug 3, 2016

Why would you need to? You can add to the files field as needed but not revert.

@sebmarkbage
Copy link
Collaborator

Ah. I can add lib/ to the other packages like you did for react.

@zpao zpao modified the milestones: 15.3.1, 15-next Aug 12, 2016
zpao added a commit that referenced this pull request Aug 12, 2016
NMinhNguyen referenced this pull request in enzymejs/react-shallow-renderer Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants