Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7099 #7251

Merged
merged 2 commits into from
Jul 13, 2016
Merged

Fix #7099 #7251

merged 2 commits into from
Jul 13, 2016

Conversation

troydemonbreun
Copy link
Contributor

Fix for #7099

zpao
zpao reviewed Jul 12, 2016
View reviewed changes
src/renderers/dom/client/wrappers/ReactDOMInput.js
@@ -64,6 +64,7 @@ var ReactDOMInput = {
// Make sure we set .type before any other properties (setting .value
// before .type means .value is lost in IE11 and below)
type: undefined,
step: undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment about why we're setting step as well.

@troydemonbreun
Copy link
Contributor Author

@zpao Comments updated

@ghost ghost added the CLA Signed label Jul 12, 2016
@zpao
Copy link
Member

zpao commented Jul 13, 2016

Sounds like what @spicyj was alluding to in #7099 so let's do it. Thanks!

@zpao zpao merged commit fc04310 into facebook:master Jul 13, 2016
@zpao zpao added this to the 15-next milestone Jul 13, 2016
zpao pushed a commit that referenced this pull request Jul 13, 2016
@troydemonbreun @zpao
Fix #7099 (#7251)
14e6a69 
* Set step prop before value prop

* Embed comments on .step sequence behavior

(cherry picked from commit fc04310)
@zpao zpao modified the milestones: 15-next, 15.3.0 Jul 13, 2016
@troydemonbreun troydemonbreun deleted the r-7099 branch July 13, 2016 21:37
@mikecao
Copy link

mikecao commented Jul 30, 2016

@troydemonbreun The min/max properties on the range input also cause the same problem. Please see #7170.

@troydemonbreun
Copy link
Contributor Author

Yeah, I will fix that also, thanks!
On Jul 30, 2016 12:39 AM, "Mike Cao" [email protected] wrote:

@troydemonbreun https://github.com/troydemonbreun The min/max
properties on the range input also cause the same problem. Please see
#7170 #7170.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#7251 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAvBkEJDa_dxDzUA9rSiWjdUPhH-3fsQks5qauOigaJpZM4JKpoQ
.

@troydemonbreun troydemonbreun mentioned this pull request Aug 1, 2016
Closed
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
15.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@troydemonbreun @zpao @mikecao