Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added docs for environment integration. #6510

Merged
merged 1 commit into from
Apr 14, 2016
Merged

Added docs for environment integration. #6510

merged 1 commit into from
Apr 14, 2016

Conversation

jimfb
Copy link
Contributor

@jimfb jimfb commented Apr 14, 2016

gaearon
gaearon reviewed Apr 14, 2016
View reviewed changes
docs/docs/09.3-environments.md
}
```

If your application uses node modules, or want to transform JSX in Nashorn, you will need to do some additional environment setup. The following resources may be helpful in getting you started:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

", or want" <-- missing "you"

@gaearon
Copy link
Collaborator

gaearon commented Apr 14, 2016

Generally I’m not sure whether console.log(...) is enough to explain it or if it is actually confusing. We might want to provide some code sample like renderFullPage on this page that demonstrates what is supposed to happen to the markup after renderToString(), and then explain how the client will take over it if the checksum matches. If we already have this somewhere in the docs, we should link to it.

@jimfb jimfb force-pushed the ssr-environment-docs branch from a37f79e to 5f1109d Compare April 14, 2016 18:59
@facebook-github-bot
Copy link

@jimfb updated the pull request.

@jimfb
Copy link
Contributor Author

jimfb commented Apr 14, 2016 •
edited
Loading

Yeah, I thought about that. This is just a start, we can update later. Probably what makes the most sense is to put up a simple repository that people can check out, which has an end-to-end example, but that's a larger task. For now, let's do this incrementally.

gaearon
gaearon reviewed Apr 14, 2016
View reviewed changes
docs/docs/09.3-environments.md

## Nashorn

Nashorn is a lightweight high-performance JavaScript runtime that runs within the JVM. React should run out of the box in Java8+.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Java8+ => Java 8+.

@jimfb jimfb force-pushed the ssr-environment-docs branch from 5f1109d to 66bfee6 Compare April 14, 2016 19:25
@jimfb jimfb merged commit 6a8c751 into facebook:master Apr 14, 2016
@zpao
Copy link
Member

zpao commented Apr 14, 2016

There are some other changes I'd like so I'm just going to followup.

@jimfb
Copy link
Contributor Author

jimfb commented Apr 14, 2016 •
edited
Loading

Oh, already created followup. You can comment on other changes in #6517 if you want. Either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimfb @gaearon @facebook-github-bot @zpao