Clarify that ReactPerf.getLastMeasurements() is now opaque #6405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Should I merge it now, or wait for 15 to be released? How do we divide “needs merge to stable asap” from “needs merge to stable on next release”? |
|
Merge now but do not mark as needing to be cherry-picked to stable. |
|
How do we remember to cherry-pick it later? Is this part of the stable release process? |
|
We never cherry-pick it. When the v15 branch is cut, it will be cut from master, so it will include this commit. The cherry-picking is only for backporting the documentation to the previous stable release. |
|
Ah, that makes total sense. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents changes from #6286 and should be up on the website when 15 is released.