Error boundries should not unmount composite components which were not mounted. #5982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| render() { | ||
| if(!this.state.error) return <div>{this.props.children}</div>; |
|
What happened before? Also, can you unmount the whole thing as part of the test too? |
|
When do we get our linter back??? I suppose we always have @spicyj the human linter for when babel-eslint is broken and throwing exceptions. Before, we attempted to unmount the composite children and things would blow up with an NPE if the error had a composite sibling occurring after the angry component. |
jimfb
force-pushed
the
error-boundaries-composite-unmount
branch
from
18c085d to
86305fb
Compare
|
@jimfb updated the pull request. |
|
So we still fail if componentWillUnmount throws somewhere in the subtree – is that right? |
|
k |
|
Eww, Correct. |
jimfb
added a commit
that referenced
this pull request
Feb 5, 2016
Error boundries should not unmount composite components which were not mounted.
|
We'll need to fix that. |
This was referenced Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error boundries should not unmount composite components which were not mounted.
Fixes #5980
cc @spicyj