Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added period to comment. #5895

Closed
wants to merge 1 commit into from

Conversation

danielrussellLA
Copy link

Added period to comment starting with "Wrap a 'key' value explicitly" to align with style in traverseAllChildren.js.

Added period to comment starting with "Wrap a 'key' value explicitly" to align with style in traverseAllChildren.js.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@jimfb
Copy link
Contributor

jimfb commented Jan 21, 2016

@danielrussellLA Thanks for the PR! We love to see the community getting involved! However, tiny fixups like this should be bundled with more substantive changes. For this reason, I'm going to close out the PR, but we would love to see this change included as part of a future PR. If you're looking for a way to get started, I recommend checking out the list of good first bugs: https://github.com/facebook/react/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen++label%3A%22good+first+bug%22

@jimfb jimfb closed this Jan 21, 2016
@danielrussellLA
Copy link
Author

Thanks Jim-I'll check that article out.
Cheers.

On Wed, Jan 20, 2016 at 10:28 PM, Jim [email protected] wrote:

Closed #5895 #5895.


Reply to this email directly or view it on GitHub
#5895 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants