-
Notifications
You must be signed in to change notification settings - Fork 47.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated all dependencies. #4125
Conversation
It is for this reason that there is |
actually you should do |
Good catch @chicoxyzzy - I've actually updated all the dependencies in the latest commit. |
You can't do this blindly. There's actually a reason we're stuck at some of our dependencies (eg, by updating sauce-tunnel you actually broke some of our testing, npm-jsx_orphaned_brackets_transformer actually needs the specific version of jstransform that it specified). For many of the other things, the
If you really want to go update everything, that's a great goal. But I won't accept it blind like this. Doing it in pieces is ok. Eg, update the server-side rendering example and test it. We need to know you tested it and it worked before we ship it to a bunch of people. I'm going to close this PR out as is as a result. But if you do want to do this, I'd expect to see at least 4 separate PRs (or 1 big PR with multiple commits), each with an complete test plan. |
Thanks for the detailed response @zpao. You're right. |
Did this via npm using the following commands:
npm update --save
andnpm update --save-dev
.This will ensure we have the latest versions of every dependency at this moment. If all tests pass, I would think it is safe to believe that there are no regressions.