Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 03-interactivity-and-dynamic-uis.md #4122

Closed
wants to merge 1 commit into from

Conversation

jmarceli
Copy link

Fix typo. Props CAN'T change over time (as I suppose).

Fix typo. Props CAN'T change over time (as I suppose).
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@ericelliott
Copy link
Contributor

Props can change over time. Typically, those changes are the reason the component re-renders.

@waldreiter
Copy link
Contributor

Seems the wording causes confusion. Just three weeks ago there was #3944.

@jmarceli
Copy link
Author

Thanks for clarification in #3944, I was confused by this sentence: Try to use props as the source of truth where possible. One valid use to store props in state is to be able to know its previous values, because props can change over time. I think it might be confusing for other beginners as well.

@zpao
Copy link
Member

zpao commented Jun 13, 2015

@ericelliott & @cody are right that it is correct as written but if it's confusingly worded, let's change it. Maybe this is clearer:

… because props may change as a component is re-rendered.

@ericelliott
Copy link
Contributor

👏

@zpao
Copy link
Member

zpao commented Jul 13, 2015

No response from author so closing out and will just change myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants