Document new es6module flag in react-tools README #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +43,8 @@ option | values | default | |||
| `harmony` | `true`: enable ES6 features | `false` | |||
| `sourceFilename` | the output filename for the source map | `"source.js"` | |||
| `stripTypes` | `true`: strips out type annotations | `false` | |||
| `es6module` | `true`: parses the file as an ES6 module | 'false' | |||
| `nonStrictEs6module` | `true`: parses the file as an ES6 module, except disables implicit strict-mode (i.e. CommonJS modules et al are allowed) | 'false' | |||
There was a problem hiding this comment.
Nit: Use backticks for false
zpao
added a commit
that referenced
this pull request
Apr 8, 2015
Document new es6module flag in react-tools README
|
Looks good, thanks! Sorry that you lost some time :( |
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 13, 2015
Document new es6module flag in react-tools README
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 17, 2015
Document new es6module flag in react-tools README
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 18, 2015
Document new es6module flag in react-tools README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request documents the new JSXTransformer
es6moduleandnonStrictEs6moduleflags added a couple months ago by @jeffmo.This code was documented per the code comments given in the original PR, #3586.
It would have saved me some time if this were documented, as I was having issues getting code using
import/exportto compile. Better late than never.Note that I have completed the Facebook CLA.
Cheers!