Fix the context handling when updating a rendered component. #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks correct to me. Good catch. |
jimfb
added a commit
that referenced
this pull request
Mar 25, 2015
Fix the context handling when updating a rendered component.
zpao
added a commit
that referenced
this pull request
Mar 25, 2015
PR #3494 was based on master before we shifted to using console.error. This just fixes the new test case.
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Apr 13, 2015
Fix the context handling when updating a rendered component.
This was referenced Apr 14, 2015
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Apr 17, 2015
Fix the context handling when updating a rendered component.
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Apr 18, 2015
Fix the context handling when updating a rendered component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a component is re-rendered, the context is not properly processed for children. The new test-case demonstrates it: with the current code base, 2 warnings are emitted because of the context mismatch.
Note: this PR is based on the comments of the issue #3404.
I have accepted the CLA.