Fix HTML to JSX converter to work with https #3456
Conversation
| @@ -6,6 +6,6 @@ id: html-jsx | |||
| <div class="jsxCompiler"> | |||
| <h1>HTML to JSX Compiler</h1> | |||
| <div id="jsxCompiler"></div> | |||
| <script src="http://reactjs.github.io/react-magic/htmltojsx.min.js"></script> | |||
| <script src="https://reactjs.github.io/react-magic/htmltojsx.min.js"></script> | |||
There was a problem hiding this comment.
Why not
<script src="//reactjs.github.io/react-magic/htmltojsx.min.js"></script>
so it is protocol agnostic?
There was a problem hiding this comment.
In another PR // was used at first, but it was argued that the prefix should be https//: #3180 (comment)
@zpao I am happy to change this, just let me know.
|
+1 if you make it // instead of https:// |
|
This is good as-is – thanks! |
Fix HTML to JSX converter to work with https
|
Thanks - I'm curious as to why this only broke recently though? Is the React site loading via HTTPS now but it never used to? |
|
The link to the conversion page is relative, so it'll only break if they originally landed on the github pages domain using https (which is not the default). I have the https-everywhere extension which is why it broke for me. react/docs/docs/02.1-jsx-in-depth.md Line 87 in ccb5ccd |
Fix HTML to JSX converter to work with https
|
Looks like we never merged this to stable. |
|
This was landed before the stable branch was cut and you can see this code in the branch. |
Fixes #3455