Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] feat[Tree]: set initial scroll offset when inspected element index is set #31968

Merged
merged 1 commit into from
Jan 9, 2025
Merged

[DevTools] feat[Tree]: set initial scroll offset when inspected element index is set #31968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/react-devtools-shared/src/devtools/views/Components/Tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,22 @@ export type ItemData = {
treeFocused: boolean,
};

function calculateInitialScrollOffset(
inspectedElementIndex: number | null,
elementHeight: number,
): number | void {
if (inspectedElementIndex === null) {
return undefined;
}

if (inspectedElementIndex < 3) {
return undefined;
}

// Make 3 elements on top of the inspected one visible
return (inspectedElementIndex - 3) * elementHeight;
}

export default function Tree(): React.Node {
const dispatch = useContext(TreeDispatcherContext);
const {
Expand Down Expand Up @@ -401,6 +417,10 @@ export default function Tree(): React.Node {
<FixedSizeList
className={styles.List}
height={height}
initialScrollOffset={calculateInitialScrollOffset(
inspectedElementIndex,
lineHeight,
)}
innerElementType={InnerElementType}
itemCount={numElements}
itemData={itemData}
Expand Down
Loading